songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
76,571 Commits 3 Branches 156 Tags 974 MiB
Commit Graph

76571 Commits

Author SHA1 Message Date
Mael Rouxel-Labbé f7405c8f96 Cleaned example: ex_periodic_alpha_shapes_2.cpp 2017-08-23 16:26:29 +02:00
Mael Rouxel-Labbé 63d293765f Added an assertion to forbid using ExactComparisonTag with periodic triangulations 
When we set the exact comparison tag to true, we use a lazy evaluation
of predicates and store pointers to the arguments of the predicates (that is,
pointer to points). However, the points are  -- in the case of periodic --
only temporary objects and it is thus dangerous to take pointers to those
temporary values because the pointers quickly become invalid.

Thus, periodic triangulations are not allowed to use the exact tag.

A possible way to make it work is to define a small class:
Periodic_triangulation_with_stored_real_points that would inherit the base
(periodic) triangulation but store all the points of its simplices.
Then, the function  point(face_handle, int) would return an entry of that
container, of which it would be safe to take a pointer.
 2017-08-23 16:19:32 +02:00
Mael Rouxel-Labbé aaeaf35380 Introduced the tag "Periodic_tag" to mark distinguish periodic triangulations 2017-08-23 16:18:05 +02:00
Mael Rouxel-Labbé e3d27128fb Minor doc changes to Alpha Shapes 3 2017-08-23 11:10:12 +02:00
Mael Rouxel-Labbé 11283967a7 Added periodic example in Alpha Shapes 2D 2017-08-23 11:09:55 +02:00
Mael Rouxel-Labbé ad27f5c39b Readability changes in Alpha_shapes_2 2017-08-23 11:04:46 +02:00
Mael Rouxel-Labbé 72908fc076 Readability changes in Alpha_Shapes_3 2017-08-23 11:04:21 +02:00
Mael Rouxel-Labbé cc94a3aa86 Documented periodic triangulations in alpha shapes 2 2017-08-23 11:03:36 +02:00
Mael Rouxel-Labbé 87e9bb4c43 Changed Alpha_shapes_2 to work with periodic triangulations 2017-08-23 11:02:52 +02:00
Mael Rouxel-Labbé d4d55453d7 Added a point() function to Triangulation_2 
Necessary for Alpha_shapes_2 because some triangulations (e.g. P2T2) cannot
use v->point() but must use tr.point(v)
 2017-08-23 11:00:50 +02:00
Mael Rouxel-Labbé 84d11ac797 Fixed Offset definition in P3T3's static filtered predicates 2017-08-23 11:00:03 +02:00
Mael Rouxel-Labbé f6da2ed7dc Static filter must be templated by the traits, not the kernel 2017-08-23 10:59:40 +02:00
Mael Rouxel-Labbé 1cc8449b34 Fixed using Point's default constructor instead of the base's operator() 2017-08-23 10:59:18 +02:00
Mael Rouxel-Labbé cf01313055 Fixed some P3T3 doc 2017-08-23 10:59:09 +02:00
Mael Rouxel-Labbé 252f541f5f Removed useless P2Tvertex_base void specialization 2017-08-23 10:57:57 +02:00
Mael Rouxel-Labbé 0106de5fd0 Misc minor changes 2017-08-23 10:57:48 +02:00
Mael Rouxel-Labbé 11c3a490d1 Added functions / enum necessary for P2DT2 to be usable in 2D Alpha Shapes 2017-08-23 10:52:30 +02:00
Mael Rouxel-Labbé 9b570830f0 Removed useless includes 2017-08-23 10:50:57 +02:00
Mael Rouxel-Labbé c987e0f59e Renamed P2DT2 base class typedef 2017-08-23 10:50:20 +02:00
Mael Rouxel-Labbé 95e110f0ba Fixed traits usage in P2T2 
P2DT2 must use P2DTT2, not P2TT2...
 2017-08-23 10:48:06 +02:00
Mael Rouxel-Labbé 25b3d8480f Fixed various issues in P2T2 doc 2017-08-23 10:43:53 +02:00
Mael Rouxel-Labbé 5695143729 Moved some functions from P2T2 to P2DT2 
circumcenter, side_of_oriented_circle, etc. have nothing to do with P2T2 and
actually will not work if some user decides to use a model of the traits concept
because construct_circumcenter_2 and side_of_oriented_circle_2 are required
by delaunay traits, not triangulation traits.

Doc changed accordingly
 2017-08-22 17:38:40 +02:00
Mael Rouxel-Labbé b5fd4dfa01 Removed useless include 2017-08-22 17:34:05 +02:00
Mael Rouxel-Labbé addaf298c7 Removed Periodic_2_triangulation_hierarchy_vertex_base_2 
This class is a needless duplicate of Triangulation_hierarchy_vertex_2.

Also, actually use the periodic hierarchy in the examples/tests...
 2017-08-22 17:29:56 +02:00
Mael Rouxel-Labbé 06d977885f Fixed PT2 hierarchy's doc using imaginary concepts 2017-08-22 16:52:46 +02:00
Mael Rouxel-Labbé bd135557fa Fixed P2T2's concept description 
P2DTT2 is not a model of Periodic_2TriangulationTraits_2
 2017-08-22 14:24:28 +02:00
Mael Rouxel-Labbé b9c9a67bbc Fixed Compute_squared_radius_2's return type 2017-08-22 14:22:25 +02:00
Mael Rouxel-Labbé af86bfca8b Renamed P3T3's offset-handling functors (added a _3 suffix) 2017-08-22 13:38:31 +02:00
Mael Rouxel-Labbé 391c737108 Fixed 2D periodic traits 
This is aligned on P3T3 new traits on actually use filtered and statically
filtered traits (automatically selected).
 2017-08-22 13:35:45 +02:00
Sébastien Loriot d5bca02dbe Merge remote-tracking branch 'cgal/releases/CGAL-4.11-branch' 2017-08-18 16:30:16 +02:00
Sebastien Loriot 74409b2b3c Merge pull request #2239 from sgiraudot/Shape_detection-Region_growing-GF 
Region Growing (Shape Detection)
 2017-08-18 16:27:19 +02:00
Sebastien Loriot 7c7741f441 Merge pull request #2349 from kkatrio/CGAL-4.11-branch 
Polyhedron demo: minor fix in statistics
 2017-08-18 16:18:46 +02:00
Sébastien Loriot 07f6151b06 fix help display 2017-08-18 11:13:52 +02:00
Simon Giraudot b0593e5332 Fix warning conversion int/std::size_t 2017-08-17 09:52:06 +02:00
Sébastien Loriot 694c8a5223 Merge remote-tracking branch 'cgal/releases/CGAL-4.11-branch' into HEAD 2017-08-16 19:58:35 +02:00
Sébastien Loriot b933084a25 Merge remote-tracking branch 'cgal/releases/CGAL-4.10-branch' into HEAD 2017-08-16 19:58:11 +02:00
Sebastien Loriot aaff465694 Merge pull request #2345 from sloriot/SMS-fix_bounded_normal_example 
Test and fix PR 2193
 2017-08-16 19:57:39 +02:00
konstantinos katrioplas 11ac8a648a accumulate areas fix 2017-08-16 20:35:46 +03:00
Sebastien Loriot 655903a4da Merge pull request #2348 from imiordanov/master 
Fix for doc bug, github issue #2346
 2017-08-16 09:02:30 +02:00
Iordan Iordanov 2d497ea826 fix for doc bug, github issue #2346 2017-08-14 14:38:01 +02:00
Simon Giraudot 335abd45dd Fix warnings 2017-08-14 09:58:33 +02:00
Sébastien Loriot 486a32c3ec fix call to named parameter function 
+add missing line to compile edge_collapse_bounded_normal_change.cpp
 2017-08-11 16:19:15 +02:00
Sébastien Loriot 287c44cc94 remove broken URLs 2017-08-11 16:17:25 +02:00
Simon Giraudot 50b618d801 Fix typename warnings 2017-08-11 10:07:11 +02:00
Simon Giraudot 6d277cffcb Fix unhandled shapes assertion error in plugin 2017-08-11 09:18:11 +02:00
Sebastien Loriot 979f683d87 Merge pull request #2338 from janetournois/BGL_OpenMeshExamples-fixCMakeLists-GF 
Some BGL examples require OpenMesh : change CMakeLists
 2017-08-10 13:48:58 +02:00
Sebastien Loriot 621ddac41f Merge pull request #2249 from sgiraudot/Read_PLY_polygon_soup-GF 
Read PLY polygon soup
 2017-08-10 13:47:50 +02:00
Sébastien Loriot 2de42e8f92 Merge remote-tracking branch 'cgal/releases/CGAL-4.11-branch' 2017-08-09 12:50:17 +02:00
Sebastien Loriot 1bcb92c749 Merge pull request #2339 from maxGimeno/Fix_selection_io-GF 
Polyhedron_demo: Fix selection_io_plugin
 2017-08-09 12:47:04 +02:00
Sebastien Loriot 7c3a3dfc21 Merge pull request #2341 from sloriot/Polynomial-fix_warning 
Fix a warning
 2017-08-09 12:45:56 +02:00