Commit Graph

1534 Commits

Author SHA1 Message Date
Jane Tournois d826147256 remove TriangleAccessor from polyhedral_mesh_complex 2017-08-03 17:15:43 +02:00
Jane Tournois 56cab9458c remove extra typename 2017-08-03 16:09:52 +02:00
Jane Tournois 0c2999da30 use forward declaration include 2017-08-03 16:09:52 +02:00
Jane Tournois 77896f38fe use the AABB_tree internal to Side_of_triangle_mesh
this avoids incompatibility issues,
and simplifies the code in Polyhedral_mesh_domain_3
2017-08-03 16:09:52 +02:00
Jane Tournois 862300b609 remove extra *
and improve indentation
2017-08-03 16:09:52 +02:00
Jane Tournois ee8eda8a16 TriangleAccessor is not needed anymore 2017-08-03 16:09:52 +02:00
Jane Tournois 9e388204e8 use Side_of_triangle_mesh in Polyhedral_mesh_domain_3 2017-08-03 16:09:52 +02:00
Laurent Rineau 917781929b Merge pull request #2279 from janetournois/Polyhedron_demo_-add_mesh_surface_w_border_in_closed_domain-GF
Qualify call of is_empty() as CentOS6-CXX11 sees an ambiguity with struct std::is_empty
2017-07-25 18:17:10 +02:00
Laurent Rineau 99bfe4b200 Fix debug code, after the BGLization 2017-07-21 17:18:51 +02:00
Laurent Rineau 5f198bca9c Bug-fix: fix a bug that could lead to a size close to 0
The bug and the fix are known for six weeks (found while working on
another project):

> commit 15d1f864c4bb68cc9e267c3be3610296e5fa9212
> Author: Laurent Rineau <laurent.rineau@cgal.org>
> Date:   Fri Feb 17 12:17:18 2017 +0100
>
>     Refactoring of Sizing_field_with_aabb_tree (API breakage too)

but we forgot to include the fix in CGAL.
2017-07-21 16:49:40 +02:00
Laurent Rineau 2ef17adaf0 Extend the test to compare with reference files
That way, if the format changes, the test will detect the change.
2017-07-18 15:53:21 +02:00
Laurent Rineau aa85aea097 Fix io_signature for Mesh_3 (since the weighted point rework) 2017-07-18 14:40:10 +02:00
Laurent Rineau ceec6140ba Merge pull request #1884 from lrineau/Mesh_3-Polyhedral_complex_mesh_domain_3-GF
New class of MeshDomainWithFeatures_3, from a polyhedral complex
2017-07-17 16:28:27 +02:00
Laurent Rineau 78f1988747 Merge pull request #2247 from lrineau/Surface_mesher-cleanup_after_Weighted_point_3-lrineau
Surface mesher: cleanup files after the move to Weighted_point_3
2017-07-17 12:24:03 +02:00
Laurent Rineau 871bba21f6 Merge pull request #2212 from MaelRL/Periodic_3_Regular_triangulation_3-APelle
Add periodic regular triangulations
2017-07-17 12:23:54 +02:00
Andreas Fabri b138cc7f9e Qualify call as CentOS6-CXX11 sees an ambiguity with struct std::is_empty 2017-07-17 11:11:42 +02:00
Laurent Rineau ef2f6cd9a8 Remove remaining use of <CGAL/Weighted_point.h> 2017-07-11 13:35:41 +02:00
Jane Tournois 0ca00822dc fix warnings
about comparison signed/unsigned
2017-07-07 11:54:24 +02:00
Jane Tournois 433d154329 variable used only in verbose mode 2017-07-07 11:27:21 +02:00
Jane Tournois 400edd0886 this can't be tested when Surface_patch_index is not only an integer 2017-07-07 11:23:59 +02:00
Jane Tournois b7597d90f7 rt.insert() takes a weighted point
fix compilation error
2017-07-07 10:56:17 +02:00
Jane Tournois ca20cea4f2 fix compilation errors after rebase 2017-07-07 10:19:08 +02:00
Andreas Fabri 5dbe78d1ec Remove typdef 2017-07-07 10:15:10 +02:00
Jane Tournois 63d793575d typos in the doc 2017-07-07 10:15:10 +02:00
Jane Tournois b47a4eec3e Partially Revert "allow not to protect borders and sharp features in a polyhedral complex"
This reverts commit 087c6ab1f388febb8823c66eb9d05b9229a4af93.

We now use a const_cast to solve the problem of the reverted commit
2017-07-07 10:15:10 +02:00
Jane Tournois 8a36efa436 allow not to protect borders and sharp features in a polyhedral complex
we overload construct_initial_points_object() to fill internal data structures
of Polyhedral_complex_mesh_domain_3 in case they have not been initialized yet

there were a lot of constness issues to be solved, and most internal data
structures had to be made mutable.
It seems to be a better choice and exposing a non-const mesh domain in the
outer functions as init_c3t3() for example
2017-07-07 10:15:10 +02:00
Jane Tournois b49bd34349 document the class, and set visible or not what should be 2017-07-07 10:15:10 +02:00
Jane Tournois 6692154562 doc : fix compilation, and add group 2017-07-07 10:15:10 +02:00
Jane Tournois 63cc93d15d change some private to protected, and add a constructor
to be able to use the methods in a derived class
2017-07-07 10:15:10 +02:00
Jane Tournois 0a1f3ce326 use the typedef Polyhedron_type 2017-07-07 10:15:10 +02:00
Jane Tournois db634d317e deal with duplicated points
in some configurations where the input is non-manifold at a vertex,
there might be duplicated points.
When this happens, we want to merge the incident surface patches
to preserve meshing with the topology criterion from not terminating
2017-07-07 10:15:10 +02:00
Jane Tournois 06434bda1a fix add_vertices_to_c3t3_on_patch_without_feature_edges(C3t3& c3t3)
the implementation was incomplete
2017-07-07 10:15:10 +02:00
Jane Tournois 8d54b6f970 remove functions that have become useless
because we do not restrict to cuboid-like domains,
we can use is_sharp, detect_sharp_edges, and detect_border_edges
from Detect_features_in_polyhedra instead of these specific implementations
2017-07-07 10:15:10 +02:00
Jane Tournois 9fc794ec14 add missing ref 2017-07-07 10:15:10 +02:00
Jane Tournois 82da7a8f61 write detect_borders() and detect_features()
as done in CGAL::Polyhedral_mesh_domain_with_features_3
2017-07-07 10:15:10 +02:00
Jane Tournois 80e3ce68dd do not detect sharp features in constructor
and do not consider that sharp edges have to be on the bbox
2017-07-07 10:15:10 +02:00
Jane Tournois 675f54334b add comments 2017-07-07 10:15:10 +02:00
Jane Tournois 46d31b6f48 fix compilation for visual studio
msvc 2013 fails to match IGT with the local IGT, and mismatches
with the one from the Base class.

this commit is enough to help it match types
2017-07-07 10:15:10 +02:00
Laurent Rineau 87d7824afc Include the license checking header 2017-07-07 10:15:10 +02:00
Laurent Rineau abc6c0697f Fix the stupid name lookup bug from Visual C++
```
...\include\CGAL/Polyhedral_complex_mesh_domain_3.h(283): error C2248: 'CGAL::Polyhedral_mesh_domain_3<Polyhedron,IGT,TriangleAccessor,CGAL::Tag_true,CGAL::Tag_true>::IGT': cannot access private typedef declared in class 'CGAL::Polyhedral_mesh_domain_3<Polyhedron,IGT,TriangleAccessor,CGAL::Tag_true,CGAL::Tag_true>'
        with
        [
            Polyhedron=CGAL::Polyhedron_3<K,CGAL::Mesh_3::Mesh_polyhedron_items<int>,CGAL::HalfedgeDS_default,std::allocator<int>>,
            IGT=K,
            TriangleAccessor=CGAL::Triangle_accessor_3<CGAL::Polyhedron_3<K,CGAL::Mesh_3::Mesh_polyhedron_items<int>,CGAL::HalfedgeDS_default,std::allocator<int>>,K>
        ]
...\include\CGAL/Polyhedral_mesh_domain_3.h(169): note: see declaration of 'CGAL::Polyhedral_mesh_domain_3<Polyhedron,IGT,TriangleAccessor,CGAL::Tag_true,CGAL::Tag_true>::IGT'
        with
        [
            Polyhedron=CGAL::Polyhedron_3<K,CGAL::Mesh_3::Mesh_polyhedron_items<int>,CGAL::HalfedgeDS_default,std::allocator<int>>,
            IGT=K,
            TriangleAccessor=CGAL::Triangle_accessor_3<CGAL::Polyhedron_3<K,CGAL::Mesh_3::Mesh_polyhedron_items<int>,CGAL::HalfedgeDS_default,std::allocator<int>>,K>
        ]
```
2017-07-07 10:15:10 +02:00
Laurent Rineau afa62cbb40 First draft of a documentation for Polyhedral_complex_mesh_domain_3 2017-07-07 10:15:10 +02:00
Laurent Rineau c4fea992cb Add an example and a class: Polyhedral_complex_mesh_domain_3 2017-07-07 10:15:10 +02:00
Maxime Gimeno 2e5b2d5d84 Fix mesh_3_plugin with SM 2017-07-05 16:59:11 +02:00
Mael Rouxel-Labbé 5ef4ed6083 Merge branch 'Periodic_3_Regular_triangulation_3-APelle-old' into Periodic_3_Regular_triangulation_3-APelle
Based on master
2017-07-03 16:12:14 +02:00
Laurent Rineau d878561809 Merge pull request #2102 from afabri/Kernel_Weighted_point_without_conversion-GF
Remove implicit conversions between points and weighted points
2017-07-03 12:08:57 +02:00
Mael Rouxel-Labbé ce8f3ff2d9 Fixed unused variable warning 2017-06-28 10:17:14 +02:00
Mael Rouxel-Labbé 044deb6c7e Replaced boost_static_assert with cgal_static_assert and used () guards 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé aed94b400b Renamed Compact_mesh_cell_base_3's circumcenter_ to weighted_circumcenter_ 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé 1f14a66d94 Renamed uses of invalidate_circumcenter() in accordance with the modified concept 2017-06-28 10:16:23 +02:00
Mael Rouxel-Labbé d2fe610870 Fixed Robust_weighted_[...]_traits offering a weighted API for squared_radius_3
This is artifically creating implicit conversions, which we are removing
2017-06-28 10:16:23 +02:00