Commit Graph

3625 Commits

Author SHA1 Message Date
Sébastien Loriot 2280bea679 add missing inline 2020-03-10 10:57:52 +01:00
Mael Rouxel-Labbé 23c3da94b0 Fix using now-removed named parameter helper 2020-03-10 09:07:37 +01:00
Mael Rouxel-Labbé 63e1a33a4f Add missing #include 2020-03-10 09:07:23 +01:00
Mael Rouxel-Labbé ff8a21f6e6 Minor doc rephrase (dynamic pmap is not always non-constant time access) 2020-03-09 11:49:21 +01:00
Mael Rouxel-Labbé 544dbb441a Add more information about index maps in BGL/PMP's NamedParameters.txt 2020-03-09 10:53:48 +01:00
Mael Rouxel-Labbé e8757d451a Clarify doc of PMP::clip
The face_index_map must be writable or stay well-initialized throughout
creation and deletion of faces.
2020-03-09 10:02:44 +01:00
Mael Rouxel-Labbé 645d81d298 Clean documentation
These mentions can be regrouped in the namedparameters.txt file
2020-03-09 09:59:41 +01:00
Mael Rouxel-Labbé 550138a116 Update PMP::clip tests (the pmaps must be initialized) 2020-03-09 09:58:48 +01:00
Mael Rouxel-Labbé 54b5f74edd Remove obsolete call dispatcher mechanism
Which also was kinda broken: if a face index map was actually passed as
named parameter, it would be ignored.
2020-03-09 09:57:13 +01:00
Mael Rouxel-Labbé d7f24b98e8 Correctly initialize face index maps in coref/autoref 2020-03-09 09:56:55 +01:00
Mael Rouxel-Labbé 84186fc78f Allow face index maps of different type in Face_graph_output_builder
+ don't take references to property maps
2020-03-09 09:55:58 +01:00
Mael Rouxel-Labbé 9d5ce20393 Clean doc 2020-03-06 18:16:37 +01:00
Mael Rouxel-Labbé 38da5ae2c4 Rename 'faces' parameter to avoid conflict with function 'faces(FaceGraph)' 2020-03-06 15:30:39 +01:00
Mael Rouxel-Labbé ad62f89a20 Use the new index map initializer functions and fix doc 2020-03-06 15:25:38 +01:00
Mael Rouxel-Labbé 798a476d63 Merge branch 'PMP-Default_pmap-maxGimeno-old' into PMP-Default_pmap-maxGimeno 2020-03-06 13:20:00 +01:00
Mael Rouxel-Labbé 3d7b084c66 Merge branch 'PMP-Fix_merge_duplicated_vertices-GF-old' into PMP-Fix_merge_duplicated_vertices-GF 2020-03-06 12:59:36 +01:00
Mael 150d6cbe44 Uniformize todos 2020-03-06 12:18:32 +01:00
Mael Rouxel-Labbé e3efff2d7e Disable remove_self_intersections examples/tests 2020-03-06 12:15:11 +01:00
Mael Rouxel-Labbé 8d4313f7a8 Merge branch 'PMP-Make_remove_self_intersections_local-GF-old' into PMP-Make_remove_self_intersections_local-GF 2020-03-06 12:13:30 +01:00
Mael Rouxel-Labbé 0133e9f2f9 Merge branch 'PMP-soup_to_mesh_add_vpm-old' into PMP-soup_to_mesh_add_vpm 2020-03-06 11:41:31 +01:00
Mael Rouxel-Labbé 4a77f29804 Replace index map validity runtime check with an assertion 2020-03-05 17:02:25 +01:00
Mael Rouxel-Labbé 96b6cd002b Remove obsolete call to index map initializations
These maps are obtained using get_initialized_face_index_map(g, np)
2020-03-05 15:32:02 +01:00
Laurent Rineau 79699f9fc2 Merge pull request #4259 from MaelRL/PMP-Snapping_improvements-GF
PMP: Improvements for snapping
2020-03-05 15:06:46 +01:00
Jane Tournois 21ee697498 merge both `if` conditions 2020-03-05 15:02:55 +01:00
Laurent Rineau b281902cf9 Merge pull request #4551 from MaelRL/CGAL-Fix_todo_doc_warning-GF
PMP: Fix doxygen warnings
2020-03-05 14:52:03 +01:00
Jane Tournois dd2c0e4e89 consider surface patches border halfedges as PATCH_BORDERS
surface patch borders should be considered similarly to constrained edges,
so that they still represent the same polyline after remeshing
+ it is what is documented
2020-03-05 12:27:20 +01:00
Mael Rouxel-Labbé 14582b1be9 Fix compilation (wrong mesh type) 2020-03-05 11:42:54 +01:00
Mael Rouxel-Labbé ca68f22f8d Update usage of internal index map initializer to new API 2020-03-04 14:20:56 +01:00
Mael Rouxel-Labbé 432d5c724a Improve usages of get_initialized_xxx_index_map 2020-03-04 13:37:09 +01:00
Mael Rouxel-Labbé 889108e253 Update get_initialize_xxx_index_map usages to new API 2020-03-04 12:58:42 +01:00
Mael Rouxel-Labbé c4ea4d9d99 More doc fixes 2020-03-02 13:35:43 +01:00
Mael Rouxel-Labbé d5892508c3 Store the squared lengths, avoid sqrt calls 2020-03-02 13:33:43 +01:00
Mael Rouxel-Labbé 8b53222ce2 Avoid asserting deep down when test parameters aren't passed 2020-03-02 12:51:18 +01:00
Mael Rouxel-Labbé 05703c10b9 Fix somes issues in the doc of PMP::distance.h 2020-03-02 12:43:09 +01:00
Mael Rouxel-Labbé 8ed12b7ec0 Add undocumented template parameters 2020-03-02 12:13:15 +01:00
Mael Rouxel-Labbé 83dbc1345f Use const& to points 2020-03-02 12:13:02 +01:00
Mael Rouxel-Labbé b57a1d7378 Replace BOOST_FOREACH by modern for loop 2020-03-02 12:12:30 +01:00
Mael Rouxel-Labbé 7ffb30838d Uniformize member names 2020-03-02 12:11:48 +01:00
Mael Rouxel-Labbé d1da11a502 Avoid some copies of named parameters 2020-03-02 12:10:35 +01:00
Mael Rouxel-Labbé 1c3e412cfd Rename template parameter for clarity 2020-03-02 11:44:21 +01:00
Mael Rouxel-Labbé a17d6a853e Fix includes 2020-03-02 11:42:54 +01:00
Mael Rouxel-Labbé 6b58618ba6 Clean code (indentation, trailing whitespace etc.) 2020-03-02 11:42:36 +01:00
Mael Rouxel-Labbé 71f2474944 Fix leftover '///' that ought to be '//'
Causes issues with Doxygen
2020-03-02 09:42:54 +01:00
Mael Rouxel-Labbé c6fa8c03b5 Uniformize todos 2020-03-02 09:42:35 +01:00
Mael 6b147c89a0
Fix doc 2020-02-28 13:59:42 +01:00
Mael 733fd95df7
Misc cleaning 2020-02-28 13:58:19 +01:00
Mael Rouxel-Labbé badbee5c31 Minor doc fixes 2020-02-28 13:27:44 +01:00
Mael Rouxel-Labbé 09efb802c3 Add a line about PMP::PM_to_PS to the user manual + link in ref manual 2020-02-28 13:07:02 +01:00
Mael Rouxel-Labbé 994b4858b2 Doc fixes 2020-02-28 12:56:38 +01:00
Mael Rouxel-Labbé 26463ded7a Update NPs using default constructed default values to new API
+ misc cleaning
2020-02-28 11:55:17 +01:00
Mael Rouxel-Labbé fb64638173 Clean example/test 2020-02-27 16:10:09 +01:00
Mael Rouxel-Labbé 09cb327ac3 Use dummy initialization to silence a warning 2020-02-27 09:19:49 +01:00
Mael Rouxel-Labbé 5f542ffa00 Remove snap examples from PMP-examples' CMakeLists.txt (for now) 2020-02-26 08:58:26 +01:00
Mael Rouxel-Labbé f9c6cea0fd Hide debug code behind macros 2020-02-25 15:30:11 +01:00
Mael Rouxel-Labbé 0c77ffe593 Fix includes 2020-02-25 15:29:56 +01:00
Sébastien Loriot 03bf465cb7 use predicates 2020-02-25 15:28:15 +01:00
Mael Rouxel-Labbé fc9597ac1c Add another test for merge_duplicate_vertices_on_boundary_cycles 2020-02-25 15:23:47 +01:00
Mael Rouxel-Labbé 916573af3d Fix and enhance merge_duplicate_vertices_in_boundary_cycles
Bug fix: improper check of overlapping intervals
Enhancement: don't throw everything as soon as there is a pair
             of intervals that are incompatible, only remove
	     one of the intervals (taken arbitrarily as the widest)
2020-02-25 15:21:19 +01:00
Maxime Gimeno 9a454ca7e2 Changes after review 2020-02-21 11:43:08 +01:00
Maxime Gimeno 077a129216 Merge remote-tracking branch 'cgal/master' into PMP-Default_pmap-maxGimeno 2020-02-21 10:34:14 +01:00
Mael Rouxel-Labbé 636665a96c Fix types 2020-02-20 12:14:27 +01:00
Mael Rouxel-Labbé 835ab5a0fb Test polygon_mesh_to_polygon_soup 2020-02-20 11:14:18 +01:00
Mael Rouxel-Labbé 9c51e3fba7 Add polygon_mesh_to_polygon_soup() 2020-02-20 11:14:06 +01:00
Mael Rouxel-Labbé ec6a4dbd17 Fix documentation 2020-02-20 11:13:18 +01:00
Mael Rouxel-Labbé 554be421d9 Add convience overloads for PS_to_PM_converter (no property maps passed) 2020-02-20 11:12:40 +01:00
Mael Rouxel-Labbé 21763ff4bf Fix unused typedef warning 2020-02-20 11:11:32 +01:00
Mael Rouxel-Labbé 5db42d1e8b Fix order of template parameters 2020-02-19 18:24:31 +01:00
Mael Rouxel-Labbé 7431c0751a Enhance a bit the test with a dmap instead of the default VPM 2020-02-19 18:14:45 +01:00
Mael Rouxel-Labbé 40be8e4b46 Test named parameters of PMP::PS_to_PM 2020-02-19 18:04:14 +01:00
Mael Rouxel-Labbé a6f7d08e91 Add document for NP::point_map in PMP's named parameters 2020-02-19 18:03:58 +01:00
Mael Rouxel-Labbé 51f4831d1f Add point_map and vertex_point_map NP to PMP::PS_to_PM 2020-02-19 18:01:45 +01:00
Mael Rouxel-Labbé 832090c249 Merge branch 'PMP-soup_to_mesh_add_vpm-old' into PMP-soup_to_mesh_add_vpm 2020-02-19 17:28:54 +01:00
Mael Rouxel-Labbé 35eaa07bde Misc cleaning 2020-02-19 16:49:11 +01:00
Mael Rouxel-Labbé 1a4858a6fa Fix includes 2020-02-19 16:37:32 +01:00
Mael Rouxel-Labbé 374870a6cb Misc minor fixes 2020-02-19 16:07:55 +01:00
Maxime Gimeno 7ec84ae69c replace the functor by overloads of a free function 2020-02-18 14:42:53 +01:00
Maxime Gimeno 5538786eff Merge remote-tracking branch 'cgal/master' into PMP-Default_pmap-maxGimeno 2020-02-14 15:00:54 +01:00
Laurent Rineau 034bc95674 Merge pull request #4506 from sloriot/PMP-clip_better_doc
Improve clip doc and tests
2020-02-14 14:46:32 +01:00
Laurent Rineau b7c237515a Merge pull request #4524 from sloriot/PMP-inplace_bo_fix
Handle the case of interior vertex
2020-02-14 14:46:19 +01:00
Laurent Rineau 31416b1cf2 Merge pull request #4506 from sloriot/PMP-clip_better_doc
Improve clip doc and tests
2020-02-14 14:45:55 +01:00
Laurent Rineau a98583f1ec Merge pull request #4506 from sloriot/PMP-clip_better_doc
Improve clip doc and tests
2020-02-14 14:39:19 +01:00
Laurent Rineau 16e7715c31 Merge pull request #4524 from sloriot/PMP-inplace_bo_fix
Handle the case of interior vertex
2020-02-14 14:39:05 +01:00
Maxime Gimeno 249eb85060 fixes 2020-02-14 14:25:28 +01:00
Maxime Gimeno b55239023d Doc fixes 2020-02-14 09:09:53 +01:00
Maxime Gimeno 1179b0a934 Fixes after review 2020-02-13 16:11:53 +01:00
Maxime Gimeno 201932abfb Merge remote-tracking branch 'cgal/master' into Doc_enhancements_and_clarifications-GF 2020-02-13 15:05:38 +01:00
Sébastien Loriot 3501af6c61 handle the case of interior vertex
The vertex becomes interior after the stitch of the patch
while being the endpoint of a polyline to be removed

fix patch introduced in 6e31445f62
2020-02-13 14:38:19 +01:00
Mael Rouxel-Labbé a520ac8285 Clean examples 2020-02-11 16:43:10 +01:00
Maxime Gimeno 6db578509d add np to bbox() 2020-02-11 14:47:46 +01:00
Maxime Gimeno e9864cf874 Fixes after review 2020-02-11 14:13:56 +01:00
Maxime Gimeno 0378d7825f Merge remote-tracking branch 'cgal/master' into PMP-Add_split_to_clip-GF 2020-02-10 15:53:05 +01:00
Maxime Gimeno f60d8d24ec more fixes after review 2020-02-10 14:41:05 +01:00
Maxime Gimeno 4716359ca6 Merge remote-tracking branch 'cgal/master' into PMP-new_functions-GF 2020-02-10 14:29:56 +01:00
Maxime Gimeno e3ace2289d First batch of fixes after review 2020-02-10 14:28:45 +01:00
Simon Giraudot ea30bcc85d Fix remaining CMakeLists.txt 2020-02-10 11:57:56 +01:00
Simon Giraudot 6c8fd43ebb Use CGAL_target_use_* mechanism for Eigen, LASLIB, OpenCV, TensorFlow, GLPK, SCIP, Boost IOStreams and Serialization 2020-02-10 11:57:56 +01:00
Mael Rouxel-Labbé cb3e5cd83c Merge branch 'PMP-Make_remove_self_intersections_local-GF-old' into PMP-Make_remove_self_intersections_local-GF 2020-02-07 17:09:59 +01:00
Mael Rouxel-Labbé 119f5b913b Add some data 2020-02-07 16:51:24 +01:00
Mael bb4247e143
Merge branch 'master' into PMP-Snapping_improvements-GF 2020-02-07 16:31:28 +01:00
Laurent Rineau 49a06e9201 Merge pull request #4362 from afabri/Box_intersection_d-accelerate-GF
PMP::self_intersections: Add Concurrency
2020-02-07 16:25:06 +01:00
Laurent Rineau 0fd7bbc4ff Merge pull request #4364 from afabri/CGAL-Parallel_if_available_tag
CGAL:: Add Parallel_if_available_tag
2020-02-07 16:25:03 +01:00
Laurent Rineau 226462c295 Merge pull request #4414 from oleg-alexandrov/master
Set the precision when saving a mesh
2020-02-07 16:25:00 +01:00
Laurent Rineau 21570cde72 Merge pull request #4416 from sloriot/PMP-clip_box
Add clipping overload to a iso-cuboid
2020-02-07 16:24:57 +01:00
Laurent Rineau 36cb11d01b Merge pull request #4417 from sloriot/PMP-cc_remove_boost_call
Remove call to boost in PMP::connected_components
2020-02-07 16:24:55 +01:00
Laurent Rineau 3e8b1cc503 Merge pull request #4455 from oleg-alexandrov/holeFill
Add control over hole size in the hole-filling example
2020-02-07 16:24:42 +01:00
Laurent Rineau c490d01e7f Merge pull request #4489 from MaelRL/PMP-Relax_assertion_in_compute_normal-GF
PMP: Fixes for compute_normals
2020-02-07 16:24:36 +01:00
Mael Rouxel-Labbé 84215c95c4 Merge branch 'Box_intersection_d-accelerate-GF-old' into Box_intersection_d-accelerate-GF 2020-02-07 11:03:07 +01:00
Mael Rouxel-Labbé 682254a3b8 Change test's debug macros 2020-02-06 17:19:36 +01:00
Mael Rouxel-Labbé b7ed9716b0 Fix includes to removed header 2020-02-06 17:14:57 +01:00
Mael Rouxel-Labbé b7d2646421 Fix sanity check not failing on self-intersections 2020-02-06 17:14:29 +01:00
Mael Rouxel-Labbé 29ddd67b8d Clean temp code 2020-02-06 17:14:16 +01:00
Mael Rouxel-Labbé f1969fc5b8 Remove unused debug functions 2020-02-06 16:18:42 +01:00
Mael Rouxel-Labbé 0ddf33c9df Use PM_to_PS in the demo 2020-02-06 16:15:15 +01:00
Mael Rouxel-Labbé 035536527c Misc cleaning 2020-02-06 15:49:33 +01:00
Mael Rouxel-Labbé 5202712322 Fix polygon soup initialization 2020-02-06 15:49:00 +01:00
Mael Rouxel-Labbé 3f32279011 More null angle handling in smoothing 2020-02-06 15:48:22 +01:00
Mael Rouxel-Labbé 19c7ea8f30 Remove non-existent header 2020-02-06 12:06:54 +01:00
Mael Rouxel-Labbé c2baf0a2ae Add missing ';' 2020-02-06 12:02:41 +01:00
Sébastien Loriot 23f66eeed3 splitter vpm is not needed to duplicate halfedge in tm 2020-02-06 11:48:46 +01:00
Mael Rouxel-Labbé 239d4479fa Try to work around stretched faces giving 0 angle in smoothing 2020-02-06 09:56:22 +01:00
Mael Rouxel-Labbé af075b2033 Remove assertion that can be triggered by numerical errors 2020-02-06 09:55:10 +01:00
Mael Rouxel-Labbé f33618e5e8 Uniformize macros 2020-02-06 09:54:35 +01:00
Sébastien Loriot ccfd82bfb9 improve doc and test 2020-02-05 19:09:08 +01:00
Mael dca752395e
Remove assertion 2020-02-05 18:28:08 +01:00
Mael Rouxel-Labbé e72756eb0a Mini code cleaning 2020-02-05 18:11:26 +01:00
Mael Rouxel-Labbé 0bd5511803 Add some more verbosity 2020-02-05 18:11:10 +01:00
Mael Rouxel-Labbé fb92ab7171 Do smoothing on an extracted mesh instead of the main mesh
The point is to avoid having to restore the initial mesh which is costly
and also difficult if the initial patch has non-manifoldness.
2020-02-05 18:09:51 +01:00
Mael Rouxel-Labbé bd31fb8672 Fix compilation of polygon_mesh_to_PS 2020-02-05 18:08:54 +01:00
Mael Rouxel-Labbé a2bdfd57c9 Never allow degenerate faces to be created in smoothing
Regardless of whether "safe moves only" is being used or not.

Degenerate faces are annoying because the normal is undefined (null_vector)
and then things get tricky.

The hope is that if a move would create a degenerate face, we can
just not move it, and hope that the degenerate face would not appear
on the next move.
2020-02-05 18:08:25 +01:00
Mael Rouxel-Labbé 238e18f002 Add polygon_mesh_to_polygon_soup (undocumented) 2020-02-05 15:32:22 +01:00
Mael Rouxel-Labbé 677ea630f8 Don't flip anything in weird situations 2020-02-05 11:32:40 +01:00
Mael Rouxel-Labbé 4bc3d85021 Don't test parallel features with EPECK, since it's not threadsafe 2020-02-05 10:54:26 +01:00
Mael Rouxel-Labbé 8773cee832 Minor code improvements 2020-02-05 10:54:11 +01:00
Mael Rouxel-Labbé f118be1cbf Add missing data files 2020-02-05 09:35:41 +01:00
Mael c2f99dc723
Actually use TBB in test... 2020-02-04 18:18:45 +01:00
Mael e33fa57213
Use new tag in PMP tests 2020-02-04 18:15:04 +01:00
Mael Rouxel-Labbé 0c05fc6e80 More fixes for normal computations of meshes with degenerate faces 2020-02-04 16:02:03 +01:00
Mael Rouxel-Labbé 55afaf713f Add some tests of meshes with degeneracies 2020-02-04 16:01:39 +01:00
Mael Rouxel-Labbé 20ed45589f Add some tests of meshes with degeneracies 2020-02-04 15:58:00 +01:00
Mael Rouxel-Labbé bbdc79f9b8 More fixes for normal computations of meshes with degenerate faces 2020-02-04 15:56:55 +01:00
Mael Rouxel-Labbé 33766800b6 Fix some corner cases with the new compute normals and degenerate faces 2020-02-04 14:29:08 +01:00
Mael Rouxel-Labbé eec9b0b227 Fix corner case in sin weight normal computations 2020-02-04 14:29:03 +01:00
Mael Rouxel-Labbé 1a3f0cf982 Fix corner case in sin weight normal computations 2020-02-03 18:24:08 +01:00
Mael Rouxel-Labbé a9f29a51d9 Tests improvements 2020-02-03 18:13:05 +01:00
Mael Rouxel-Labbé 81f04ac2d9 Move remove_self_intersections to PMP::experimental 2020-02-03 18:12:45 +01:00
Mael Rouxel-Labbé 6339e80f71 Remove Hausdorff checks, properly pass parameters, polish 2020-02-03 18:12:15 +01:00
Mael Rouxel-Labbé 38367410c3 Fix some corner cases with the new compute normals and degenerate faces 2020-02-03 18:10:41 +01:00
Mael Rouxel-Labbé 1eb323fcbd Relax assertion due to numerical errors that can sneak in
Logically speaking, the vector nb is the bisector of ni and nj,
so ni.nb and nj.nb are positive by construction.
2020-02-03 17:40:38 +01:00
Mael e9ca254a31
Fix using old BGL API 2020-02-03 13:27:46 +01:00
Mael Rouxel-Labbé 32aa902bf5 Merge branch 'PMP-Make_remove_self_intersections_local-GF-old' into PMP-Make_remove_self_intersections_local-GF 2020-02-03 13:05:52 +01:00