Commit Graph

110469 Commits

Author SHA1 Message Date
Sébastien Loriot c1ec62ecfb clean up 2024-11-15 15:30:45 +01:00
Sébastien Loriot c01a96b01d fix copy/paste issues 2024-11-15 13:57:27 +01:00
Sébastien Loriot 1f9ac79f75 Merge pull request #8611 from sloriot/NT-sqrt_rounding
Remove extra rounding mode changes for sqrt for interval
2024-11-15 11:41:23 +01:00
Sébastien Loriot c050bb15a3 Merge remote-tracking branch 'cgal/master' 2024-11-15 11:41:07 +01:00
Sébastien Loriot 0b6b64a390 do not change the rounding mode since protector is already created before 2024-11-15 11:33:51 +01:00
Laurent Rineau 4b1c13011f
Testsuite Summary: Fix toggle buttons behavior (#8610)
## Summary of Changes

Separate toggle button classes to prevent unwanted interactions between
Open/Close All functionality and Third Party Libraries display
2024-11-15 10:51:59 +01:00
Sébastien Loriot c7775560a4 enable filtering for Epick_d 2024-11-14 21:19:59 +01:00
Sébastien Loriot 1b4e6c6538 enable filtering with exact nt with custom traits 2024-11-14 18:39:38 +01:00
Sébastien Loriot c03bb328d6 add filtering also for Kernel with no filtering 2024-11-14 17:20:06 +01:00
Sébastien Loriot d573581411 Merge remote-tracking branch 'cgal/6.0.x-branch' 2024-11-14 14:17:47 +01:00
Sébastien Loriot f692014d1c Merge remote-tracking branch 'cgal/5.6.x-branch' into HEAD 2024-11-14 14:16:42 +01:00
Sebastien Loriot 5aec09a838
fix the fatal bug of the convolution calculation part of the Minkowski sum (#8573)
## Summary of Changes
Modify the convolution calculation part of the Minkowski sum. In the
'elimination of antennas' phase, before I fix it, only the antennas of
the first segment were eliminated, skipping the possible subsequent
antennas. For more details, please refer to the explanation in the
issue. I modified it so that if a new antenna is merged, the newly
merged antenna is used as `curr` for the next iteration; otherwise,
`after_next` is used as `curr`.


## Release Management
* Affected package(s): Minkowski_sum_2
* Issue(s) solved: fix #8551
2024-11-14 14:16:07 +01:00
Sebastien Loriot 74ea8b1f6c
Add CGAL::IO::read_OM() (#8427)
## Summary of Changes

Add a function to read an OpenMesh file ( `*.om` ) in CGALlab. This file
format stores also edges and vertices marked as features.
For the moment the function itself is not documented.

## Release Management

* License and copyright ownership: GeometryFactory
2024-11-14 14:12:26 +01:00
Nicolas Saillant 4a5b25db82 fix: isolate toggle button behaviors 2024-11-14 14:06:28 +01:00
Sebastien Loriot 79860d2ca2
Spelling correction (#8607)
Spelling correction
2024-11-14 11:00:30 +01:00
albert-github 1320a1d497 Spelling correction
Spelling correction
2024-11-14 10:22:43 +01:00
Sébastien Loriot 2df040b306 add filtering for EPECK too 2024-11-14 09:24:07 +01:00
Sébastien Loriot 2f57958cd5 Merge remote-tracking branch 'cgal/6.0.x-branch' 2024-11-14 07:48:42 +01:00
Sébastien Loriot 2e691b0d85 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-11-14 07:48:10 +01:00
Sebastien Loriot dd6adf68b3
use assume from c++23 when possible (#8597) 2024-11-14 07:42:19 +01:00
Sebastien Loriot cf31301980
PMP: Initialize to avoid warning (#8598)
## Summary of Changes

An uninitialized variable gets assigned a value inside a `for` loop,
The compiler cannot know that we always enter the loop and [warns](
https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-15/Polygon_mesh_processing_Examples/TestReport_lrineau_Ubuntu-latest-GCC6-Release.gz)
when we later use the variable.
We could use `[[assume(x)]]` to indicate that we always will enter the
loop but just initializing does the job.

## Release Management

* Affected package(s): PMP 
* License and copyright ownership: unchanged
2024-11-14 07:41:42 +01:00
Sebastien Loriot 6cb87048bd
Avoid mesh copy (#8603)
## Summary of Changes

Pass mesh by reference instead of copy

## Release Management

* Affected package(s): Surface mesh deformation
* Issue(s) solved (if any): fix #8601
2024-11-14 07:39:56 +01:00
Jane Tournois 82e2e7a267 add missing const 2024-11-12 14:46:31 +01:00
Sven Oesau f2ad1b25bc Pass mesh by reference instead of copy 2024-11-12 09:34:36 +01:00
Sébastien Loriot 333a0df9d7 also add macro for unreachable 2024-11-08 18:06:42 +01:00
Sébastien Loriot 9f83f94530 assume from c++23 2024-11-08 18:04:24 +01:00
Sébastien Loriot 13fcef62e0 missing const 2024-11-08 16:26:01 +01:00
Sébastien Loriot c8936698ac apply @MaelRL review 2024-11-08 16:22:47 +01:00
Sébastien Loriot db4404f0cc Merge remote-tracking branch 'cgal/6.0.x-branch' 2024-11-08 16:18:00 +01:00
Sebastien Loriot 400acfbf6c
remove QT_NO_KEYWORDS from CGAL::CGAL_Basic_viewer (#8581)
## Summary of Changes

Fix #8574.

## Release Management

* Affected package(s): CGAL, CMake scripts
* Issue(s) solved (if any): fix #0000, fix #0000,...
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature) [*wrong
link name to be changed*](httpssss://wrong_URL_to_be_changed/Manual/Pkg)
* License and copyright ownership:
2024-11-08 16:17:39 +01:00
Laurent Rineau 0d76bb4612 remove QT_NO_KEYWORDS from CGAL::CGAL_Basic_viewer 2024-11-08 16:16:28 +01:00
Sebastien Loriot f7ac2417b5
Fix example mesh_3D_gray_vtk_image (#7824)
## Summary of Changes

Fixes example mesh_3D_gray_vtk_image.
Changed : Meshing all value **under** isovalue --> Meshing all values
**over** isovalue.

## Release Management

* Affected package(s): Mesh_3
* Issue(s) solved (if any): 
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2024-11-08 16:11:58 +01:00
Sebastien Loriot 25afb37051
Triangulation_2: Do not include kernel header (#8527)
## Summary of Changes

Do not include `Exact_predicates_inexact_constructions_kernel.h` and
`Simple_cartesian.h`.
Change order of `#include` statements so that the  T2 files come first.
Forward declare `Epick` in `Constrained_triangulation_plus_2` where it
is used for defining a `Default` for the template parameter (which is
not documented).

## Release Management

* Affected package(s): Triangulation_2
* License and copyright ownership: unchanged.
2024-11-08 16:11:41 +01:00
Sébastien Loriot 797dde5985 Merge remote-tracking branch 'cgal/6.0.x-branch' 2024-11-08 16:11:22 +01:00
Sebastien Loriot 79ac9d9d33
Add missing methods ignore_all_XXX in graphics scene options (#8587)
## Summary of Changes

Add the 4 methods ignore_all_XXX in graphics scene options (methods that
are documented)
thanks @efifogel 

## Release Management

* Affected package(s): Basic_viewer
2024-11-08 16:10:08 +01:00
Sébastien Loriot 3abf5e760d Merge remote-tracking branch 'cgal/5.6.x-branch' into HEAD 2024-11-08 16:09:32 +01:00
Sebastien Loriot be847b419d
fix function signature (#8588) 2024-11-08 16:06:40 +01:00
Sebastien Loriot d6beacc463
[PSP3] CMake fix for OpenGR (#8591)
## Summary of Changes

Removing outdated and faulty check for compiler version

## Release Management

* Affected package(s): Point_set_processing_3, Lab (Plugin)
2024-11-08 16:06:24 +01:00
Sebastien Loriot 78c0810181 Apply suggestions from Efi 2024-11-08 15:59:42 +01:00
Garbage123King 8e59f3fc9d Update Minkowski_sum_conv_2.h
fix issue #8551
2024-11-08 15:59:42 +01:00
Guillaume Damiand 7cd3a8e653 Add missing methods ignore_all_XXX in graphics scene options (methods that are documented) 2024-11-08 15:57:10 +01:00
Laurent Rineau 0466731cf9
Issues template: minor tweaks after PR #8593 (#8599) 2024-11-08 11:37:15 +01:00
Laurent Rineau 640705e811
wip 2024-11-08 11:34:07 +01:00
Laurent Rineau 06cd13f01d
Testsuite: Add OS extraction for Windows and macOS, fix TPL init (#8595)
## Summary of Changes

- Adds OS extraction for Windows and macOS in test script.
- Fixes TPL initialization.
2024-11-08 11:31:20 +01:00
Laurent Rineau 53dd1ea488
Delete .github/ISSUE_TEMPLATE/config.yml 2024-11-08 11:26:22 +01:00
Laurent Rineau 55362f014b
Move CGAL issue template and add config settings (#8593)
## Summary of Changes

The ISSUE_TEMPLATE.md file has been moved to the ISSUE_TEMPLATE/
directory.
2024-11-08 11:24:24 +01:00
Andreas Fabri fcf062bf48 PMP: Initialize to avoid warning 2024-11-08 10:13:26 +00:00
Nicolas Saillant 8c6c08baab Add OS extraction and TPL initialization 2024-11-08 09:19:25 +01:00
Sébastien Loriot c621031992 no need to construct points 2024-11-07 18:04:03 +01:00
Sébastien Loriot 1f2f4aa4ab conditional testing 2024-11-07 18:03:50 +01:00