Andreas Fabri
8f8280ce34
Add structural filtering to Robust circumcenter traits
2023-11-23 19:37:23 +00:00
Sébastien Loriot
9cefb1a481
fix out-of-bound warnings
2023-10-19 11:40:35 +02:00
Laurent Rineau
15968e2d49
Need C++17
...
`test_simplex_iterator_3.cpp` and
`test_segment_simplex_traverser_3.cpp` require C++17.
2023-07-20 10:54:02 +02:00
Laurent Rineau
9bbebd4468
Merge pull request #7584 from sloriot/T3-fix_warnings
...
fix unused variable warnings
2023-07-12 15:23:47 +02:00
Sebastien Loriot
57b7edb6a3
Apply suggestions from code review
...
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2023-07-12 10:41:44 +02:00
Sébastien Loriot
560186b432
fix one more warning
2023-07-10 13:25:38 +02:00
Sébastien Loriot
4e6fe0c561
fix unused variable warnings
2023-07-06 18:06:03 +02:00
Laurent Rineau
4b18c7208a
fix warnings
2023-06-27 17:29:37 +02:00
Laurent Rineau
7e2e444825
Merge branch 'Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6
2023-06-21 10:19:52 +02:00
Laurent Rineau
28ab0b7c3e
another bug-fix
...
Jane and I thought that case
vertex-vertex with `ch_next != Cell_handle()`
was not possible. Let's patch that.
2023-06-21 10:19:39 +02:00
Laurent Rineau
d5f521c78c
commit improvement to debugging code
2023-06-20 18:28:36 +02:00
Laurent Rineau
53d82e5007
Merge branch 'Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6
2023-06-20 17:31:31 +02:00
Laurent Rineau
4a7f9269dc
another bug fix?!
2023-06-20 17:31:13 +02:00
Laurent Rineau
ad9efd0e18
Merge branch '5.6.x-branch' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6
...
# Conflicts:
# STL_Extension/include/CGAL/Base_with_time_stamp.h
# Triangulation_3/include/CGAL/Triangulation_3/internal/Triangulation_segment_traverser_3_impl.h
# Triangulation_3/test/Triangulation_3/CMakeLists.txt
2023-06-20 16:03:30 +02:00
Laurent Rineau
fe0dc127a3
if-guard about C++17
2023-06-20 15:14:01 +02:00
Laurent Rineau
367466c434
Merge branch '5.5.x-branch' into Triangulation_3-fix_simplex_traverser-GF
2023-06-20 14:48:05 +02:00
Laurent Rineau
4f94c70740
typos
2023-06-19 17:15:42 +02:00
Laurent Rineau
6edb602729
factorize code when cells are traversed
2023-06-19 17:11:19 +02:00
Laurent Rineau
94a1d7efdb
add special test cases
2023-06-19 17:06:31 +02:00
Laurent Rineau
14ff8c6af5
fix bugs
2023-06-19 17:06:10 +02:00
Laurent Rineau
e936fcb36b
factorize the debug function helpers
2023-06-18 21:20:19 +02:00
Laurent Rineau
f193744e66
walk_to_next_3: reformat to indentation by 2 space
2023-06-16 18:35:14 +02:00
Laurent Rineau
dcfd783953
change/fix some oddities in the code
2023-06-16 18:07:22 +02:00
Laurent Rineau
5a0c09d667
factorize/reformat the code
...
The cases `chnext == {}` and `chnext != {}` were actually very
similar.
2023-06-16 17:48:32 +02:00
Laurent Rineau
6b835a1799
use triangulation().tds().has_vertex to avoid dummies
2023-06-16 15:35:18 +02:00
Laurent Rineau
5c81b975ae
triangulation() is now a reference
2023-06-16 15:33:02 +02:00
Laurent Rineau
80a4064350
chprev/chnext
2023-06-16 15:23:50 +02:00
Laurent Rineau
461b7689ea
change the display of the test file
2023-06-16 15:00:29 +02:00
Laurent Rineau
a2a736d074
fix last bug in the test file
2023-06-16 12:48:39 +02:00
Laurent Rineau
169985ea96
fix remaining cases even with permutations
...
Now I am quite confident that the code is correct.
2023-06-16 12:37:08 +02:00
Laurent Rineau
42f8b92c1d
add comments
2023-06-16 11:50:35 +02:00
Laurent Rineau
8207105503
fix accidental use of std::optional (boost:: instead)
2023-06-15 18:07:52 +02:00
Laurent Rineau
a4a1e51e02
implementation permutations... and tests fail!
2023-06-15 17:25:16 +02:00
Laurent Rineau
8e7460108f
fix case I131I
...
The test case was wrong, because of non-exact floating points values,
in decimal.
All implemented test cases pass, now. And we do not expect missing
test cases.
Now, I should implement permutations of the four vertices of the tet.
2023-06-15 17:06:08 +02:00
Laurent Rineau
c7130e0c58
fix test case 131I
2023-06-15 16:41:07 +02:00
Laurent Rineau
4f20dc0f44
fix case 31
2023-06-15 15:50:51 +02:00
Laurent Rineau
bec374fc86
add comments: actually only one missing case
2023-06-15 14:28:02 +02:00
Laurent Rineau
f75f642b21
all test cases pass!!
...
(this commit is a cosmetic change)
All test cases pass, but:
- there are TODOs (missing cases 031, 030, 130, and 131.
- we should test with permutations of the four vertices
2023-06-15 13:21:11 +02:00
Laurent Rineau
6525e46d58
fix test case 232I
...
the test case was wrong
2023-06-15 13:17:05 +02:00
Laurent Rineau
9f4b8d5785
fix case I232
2023-06-15 13:16:28 +02:00
Laurent Rineau
00aa91967b
`prev` then `cur` is more logic
2023-06-15 12:33:00 +02:00
Laurent Rineau
e574a3a191
fix case 132I
2023-06-15 12:32:35 +02:00
Laurent Rineau
9cd8f0e8e1
fix case 12
2023-06-15 11:32:41 +02:00
Laurent Rineau
a26351455b
Add comments about missing cases
2023-06-15 10:23:01 +02:00
Laurent Rineau
b9eea8ec0d
bug-fix test case 121
2023-06-14 21:12:15 +02:00
Laurent Rineau
7b039e3761
fix test cases for I032I, and I03
...
`-.1`, and `.8` are not floating point values.
I have used `.125` (1/8) and `.5` instead.
2023-06-14 17:57:50 +02:00
Laurent Rineau
311b04a0a7
bug-fix for case "0323 with bbox"
...
The test-case was wrong.
2023-06-13 17:32:29 +02:00
Laurent Rineau
d5f5a6e2cd
buf-fix for case 032I
2023-06-13 17:19:03 +02:00
Laurent Rineau
67b2d1c770
bug-fix of case "230 with bbox"
2023-06-12 18:06:40 +02:00
Laurent Rineau
5048eb960d
bug-fix!!
...
I have been working on that issue for a few days. Eventually I found
the bug.
2023-06-12 16:45:16 +02:00