Commit Graph

105388 Commits

Author SHA1 Message Date
JacksonCampolattaro c67bec24cc More optionals for non-nullable maps 2023-09-16 18:38:32 +02:00
JacksonCampolattaro 48b502e5bb Add no-op collect_garbage(visitor) method for backwards compatibility 2023-09-16 18:22:38 +02:00
JacksonCampolattaro ce2c7a9ef5 Use optionals for more maps 2023-09-16 17:58:25 +02:00
JacksonCampolattaro bae28c3b4b Fix a typo: Gt is not a dependent type, so typename is unnecessary 2023-09-16 17:25:53 +02:00
JacksonCampolattaro e552b0d3cd Replace pointers to umap and vmap with optionals 2023-09-16 17:08:09 +02:00
JacksonCampolattaro 25790f6077 Replace nullable pmap types with std::optionals
Also not an ideal solution, but making this correct-by-construction would require more invasive refactoring.
2023-09-16 16:51:53 +02:00
JacksonCampolattaro 37d60b4ac6 Replace pointer with std::optional
This is not an ideal solution, but the Scene_points class has bigger issues.
2023-09-16 15:37:15 +02:00
JacksonCampolattaro 759905b136 Merge remote-tracking branch 'origin/orthtree-generalization' into orthtree-generalization 2023-09-16 10:26:35 +02:00
JacksonCampolattaro 4681f17ca8 Fix a small issue with the Octree definition 2023-09-16 10:24:24 +02:00
Sébastien Loriot 33dce33e0b fix some doc issues 2023-09-14 09:58:04 +02:00
Sébastien Loriot 97ed41fa5a do not document Property_container for now 2023-09-14 09:17:17 +02:00
Sébastien Loriot da33014535 Merge remote-tracking branch 'cgal/master' 2023-09-14 09:07:00 +02:00
JacksonCampolattaro d169adb98b Update benchmarks to account for recent changes 2023-09-13 16:31:37 +02:00
Laurent Rineau 187409888b Merge branch '5.6.x-branch' 2023-09-13 16:17:20 +02:00
Laurent Rineau 6a7080df9a Merge pull request #7688 from hoskillua/heat-method-doc
Added missing reference to a paper in Heat method
2023-09-13 16:17:07 +02:00
Laurent Rineau 63aa411db2 Merge pull request #7700 from albert-github/feature/bug_html_comment
Incorrect closing HTML comment
2023-09-13 16:17:05 +02:00
Laurent Rineau e04b3a4e6b Merge pull request #7703 from albert-github/feature/issue_7701
issue #7701 Appearance of "Set of Faces" in documentation.
2023-09-13 16:17:03 +02:00
Laurent Rineau 3cf928a4c7 Merge pull request #7704 from sloriot/Mesh_3-PCMD_in_domain_bug
Fix Is_in_domain potential infinite loop

# Conflicts:
#	Mesh_3/include/CGAL/Polyhedral_complex_mesh_domain_3.h
2023-09-13 16:16:23 +02:00
Laurent Rineau fe9c1236c7 Merge pull request #7705 from albert-github/feature/issue_7702
issue #7702 Appearance of " Hilbert Sorting" in documentation.
2023-09-13 16:07:47 +02:00
Laurent Rineau db008f18e7 Merge pull request #7710 from sloriot/PMP-coref_visitor_concept
Fix concept doc
2023-09-13 16:07:39 +02:00
Laurent Rineau 3c8e205372 Merge branch '5.5.x-branch' into 5.6.x-branch 2023-09-13 16:05:59 +02:00
Laurent Rineau 6fabb10744 Merge pull request #7704 from sloriot/Mesh_3-PCMD_in_domain_bug
Fix Is_in_domain potential infinite loop
2023-09-13 16:05:38 +02:00
Laurent Rineau e79e0d2033 Merge pull request #7710 from sloriot/PMP-coref_visitor_concept
Fix concept doc
2023-09-13 16:05:35 +02:00
Laurent Rineau 157782a45f Merge pull request #7710 from sloriot/PMP-coref_visitor_concept
Fix concept doc
2023-09-13 16:04:31 +02:00
Laurent Rineau 3a54848e18
Fixes for vertex/cell classes of SMDS_3 and Tetrahedral_remeshing (#7610)
## Summary of Changes

The main point of this PR is to restore the API of
`Remeshing_cell_base_3` to the initial state (since CGAL 5.1), which was
changed with the introduction of SMDS_3 in CGAL 5.6
(https://github.com/CGAL/cgal/pull/5693).

In CGAL 5.5, the class `Remeshing_cell_base_3` is templated by a geom
traits and a cell base.
In CGAL 5.6, the class became templated by only two index types,
removing the possibility to derive from custom (TDS) base cell types.

Also:
- Decompactify Simplicial_cell_base_3, allowing a cell base to be used
- Changed the API of Remeshing_vertex_base_3 to match that of
Remeshing_cell_base_3 (and other CGAL triangulations): a Gt and a Vb
- Proper rebind mechanism for VB/CB of SMDS_3 / Tetrahedral remeshing
- Various fixes of the SMDS_3 / Tetrahedral_remeshing doc.

TODO:
- [x] Announce the breaking changes in CHANGES.md
- [x] Introduce Compact_simplicial_cell_base_3?

## Release Management

* Affected package(s): `SMDS_3`, `Tetrahedral_remeshing`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): n/a
* License and copyright ownership: no change
2023-09-13 15:24:57 +02:00
Mael Rouxel-Labbé cb68fdf09e Add breaking changes 2023-09-13 15:20:11 +02:00
JacksonCampolattaro c4e6ad77f7 Update documentation for Orthtree member functions. 2023-09-13 09:19:33 +02:00
Sebastien Loriot b2c6cec8af
A missing ref
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
2023-09-12 11:08:21 +02:00
Sébastien Loriot 4f29b83610 really fix the order 2023-09-11 15:14:51 +02:00
Laurent Rineau 187003328c
Bump actions/checkout from 3 to 4 (#7709) 2023-09-11 11:55:56 +02:00
Sébastien Loriot 2905e38117 update parameter orders 2023-09-11 11:28:22 +02:00
Sébastien Loriot eebc635da0 fix concept doc 2023-09-11 09:38:27 +02:00
dependabot[bot] 4addbd6ddc
Bump actions/checkout from 3 to 4
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-09-11 05:35:00 +00:00
JacksonCampolattaro ed32969908 Prefer `using` over `typedef` universally, for consistency 2023-09-08 12:42:20 +02:00
JacksonCampolattaro 3e20800b7f Update documentation for Traits concepts 2023-09-08 12:13:27 +02:00
Mael Rouxel-Labbé 3ef293b5bd Update to new cgalModels 2023-09-08 11:41:14 +02:00
albert-github 8afc4347b4 issue #7702 Appearance of " Hilbert Sorting" in documentation.
Remove gray background and get some indentation
2023-09-07 17:43:05 +02:00
Sébastien Loriot ed521e03b0 rename macro 2023-09-07 17:33:41 +02:00
albert-github a3148fb8f5 issue #7701 Appearance of "Set of Faces" in documentation.
Remove gray background and get some indentation
(Note this proposed pull request needs the proposed pull request #7700)
2023-09-07 17:33:26 +02:00
Sébastien Loriot dd383da307 avoid an infinite loop in the case the source of the ray in on the face 2023-09-07 17:33:17 +02:00
JacksonCampolattaro ea59877c19 Automatically determine the correct typedefs for an ambient dimension using template specializations & SFINAE 2023-09-07 17:19:04 +02:00
Mael Rouxel-Labbé e2832dfe6d Merge remote-tracking branch 'cgal/master' into SMDS_3-Fix_stack-GF 2023-09-07 15:59:04 +02:00
albert-github 3d49105c91 Incorrect closing HTML comment
Newer versions of doxygen are more restrictive (and following the rules) in respect to the end comment of a HTML type of comment, i.e. `<!-- ... -->`, so parts of the paragraphs were missing
(Triangulation/index.html and Triangulation/group___pkg_triangulations_ref.html)

See also https://www.w3.org/TR/2006/REC-xml11-20060816/#sec-comments
2023-09-07 14:57:16 +02:00
JacksonCampolattaro 750ca578a8 Combine 2d, 3d, and d-d points traits into one template 2023-09-07 13:25:35 +02:00
JacksonCampolattaro 32c6d61f27 Eliminate Array and Construct_point_d_from_array 2023-09-07 11:44:14 +02:00
Laurent Rineau bf027d4154 Merge pull request #7561 from afabri/SLS-warnings-GF
SLS: Fix warnings
2023-09-07 10:49:26 +02:00
Laurent Rineau 46923342ad Merge pull request #7576 from albert-github/feature/issue_7395
issue #7395 Improvement of layout of model relations

# Conflicts:
#	Kernel_23/doc/Kernel_23/CGAL/Vector_2.h
2023-09-07 10:48:34 +02:00
Laurent Rineau cdd4b2cc75 Merge pull request #7595 from MaelRL/BGL-Generalize_FFG_doc-GF
Generalize documentation of Face_filtered_graph
2023-09-07 10:46:35 +02:00
Laurent Rineau c50c72fd28 Merge pull request #7648 from albert-github/feature/bug_pkgdesc_incl
Better showing of `#include`
2023-09-07 10:46:32 +02:00
Laurent Rineau 6ce966767b Merge pull request #7660 from afabri/Arrangement-typo-GF
Arrangement: small doc fixes
2023-09-07 10:46:26 +02:00