songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
113,740 Commits 3 Branches 156 Tags 958 MiB
Commit Graph

2844 Commits

Author SHA1 Message Date
Laurent Rineau bbc45c01fa rename to polygon_border_vertices 2024-01-29 09:34:31 +01:00
Laurent Rineau a5cf779795 debug debugging of missing faces from cavities 2024-01-26 16:36:31 +01:00
Laurent Rineau 37c5f131ac add an cmdline option to debug Steiner points 
That replaces debug macros.
 2024-01-26 16:35:52 +01:00
Laurent Rineau fb70d9dfb7 fix a bug in the dichotomy process to minimize a buggy input 2024-01-25 12:11:00 +01:00
Laurent Rineau 1b24edec3f re-add the merging of exactly coplanar faces 2024-01-25 10:56:46 +01:00
Laurent Rineau 6336e5b08a use region growing to detect almost coplanar patches 2024-01-22 23:05:07 +01:00
Sebastien Loriot 722e3825bb
Triangulation_2: Make IO save by changing file names (#7957) 
## Summary of Changes

Change file names to avoid interaction between test cases.

@MaelRL I noticed that the RT test does not read back. 

## Release Management

* Affected package(s): Triangulation_2
* Issue(s) solved (if any): fix
[testsuite](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-141/Triangulation_2/TestReport_gimeno_ArchLinux-clang.gz)
* License and copyright ownership:  unchanged
 2024-01-19 11:42:43 +01:00
Laurent Rineau d7032f5e57 new useful debugging messages 2024-01-16 15:28:44 +01:00
Laurent Rineau 73c5a2cf5f Add With_offset_tag 2024-01-16 15:27:48 +01:00
Laurent Rineau f753446633 oformat(x, tag) passed the tag value to the Output_rep 
That allows to pass an integral offset to the displayed time stamps.

The goal is to set it to -1, to display vertices IDs that are identical to the input vertices indices of `the Surface_mesh`.
 2024-01-15 09:45:25 +01:00
Laurent Rineau 939fbef9e6 new way to output after conforming 
This new way ensures that the order of vertices in the output is also the order of vertices in the CDT.
 2024-01-15 09:28:00 +01:00
Laurent Rineau 289d475ee6 vertices_in_constraint_end is bidirectional 
That allows to speed up `constraint_extremities(Constraint_id c_id)`.
 2024-01-14 20:41:17 +01:00
Laurent Rineau c6ac1e890d Add timestamps to base classes 2024-01-14 20:40:30 +01:00
Guillaume Damiand 3bc56024d3 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2024-01-11 14:08:05 +01:00
Laurent Rineau 2838441b6a cosmetic change 2024-01-09 17:26:34 +01:00
Laurent Rineau f422541cb8 faster visitor implementation during the conforming 2024-01-09 17:26:20 +01:00
Laurent Rineau de6c5f2895 change the loop pattern when there are PLC errors 
That gave a direct improvement for the four PLC error case from Thingi:

```
            name status       time     error new status   new time new error
Thingi10K_104400 FAILED   1.710520 PLC_error     FAILED   1.243950 PLC_error
Thingi10K_162100 FAILED   1.970900 PLC_error     passed   1.018690
Thingi10K_285604 FAILED  13.096400 PLC_error     FAILED   4.543940 PLC_error
Thingi10K_464846 FAILED 321.774000 PLC_error     FAILED  16.658500 PLC_error
```

One case `Thingi10K_162100` passed. And the other three got runtime
improvement before they reach the error.
 2024-01-05 16:59:55 +01:00
Laurent Rineau 06288f3f04 improve the code reproducibility 2024-01-05 16:38:53 +01:00
Laurent Rineau c25f443368 fix a regression in speed 2024-01-04 18:17:31 +01:00
Laurent Rineau ba7725ffd7 fix the CDT testsuite 
in particular test_CDT_3_insert_constrained_edge_from_EDG_file
 2024-01-04 18:08:17 +01:00
Laurent Rineau 3cb8f4dd28 restore compilation with Epeck 2024-01-04 17:18:57 +01:00
Laurent Rineau ad38e7ac29 Add diagnostic "constrained segment is too close" 2024-01-04 16:27:37 +01:00
Laurent Rineau 09de2165a8 improve diagnostic "Min distance between vertices" 2024-01-04 14:51:10 +01:00
Laurent Rineau c36bd7559d extract function encroaching_vertices(va, vb) 2024-01-04 14:50:19 +01:00
Laurent Rineau 7d9e84e685 dump region in case of a fatal PLC error 2024-01-04 14:49:31 +01:00
Laurent Rineau 87f6a352d1 factorize a lambda function 2024-01-04 14:47:45 +01:00
Laurent Rineau 9b843a901d minor improvement of debug messages 2024-01-04 14:46:53 +01:00
Laurent Rineau 6a7c2fee3c missing const 2024-01-04 14:45:47 +01:00
Laurent Rineau ee77fa000f indentation 2024-01-04 14:43:58 +01:00
Laurent Rineau 96fa9c7d95 CDT_vb_3: regroup data members 2024-01-04 14:42:25 +01:00
Sébastien Loriot c99b69a0e7 add missing license headers 2024-01-04 13:50:15 +01:00
Sébastien Loriot e7c26349f2 move header in a package to GPL 2024-01-04 13:36:34 +01:00
Andreas Fabri e610677ee2 The same for 3D 2024-01-02 17:09:24 +00:00
Sebastien Loriot caecbe29c7
Replace boost::mpl (#7813) 
- `boost::mpl::if_` --> `std::conditional`
- `boost::enable_if` -> `std::enable_if`
- `boost::mpl::and_` -> `&&`
- `boost::mpl::or_` -> `||`
- `boost::constant::bool_` -> `std::bool_constant`
- ...
 2023-12-26 17:33:36 +01:00
Laurent Rineau 62e3e8dc12 port back to C++17 
The lack of `std::set::contains` is a real pain! Using `count()`
instead reduces the readability of the code.
 2023-12-13 16:56:03 +01:00
Laurent Rineau c41a55f99b fix indentation 2023-12-13 15:44:51 +01:00
Laurent Rineau 2a74954de9 add timing displays and a --quiet option 2023-12-13 15:00:23 +01:00
Laurent Rineau 0b9133fba3 reduce timings in cases of PLC errors 2023-12-13 14:57:27 +01:00
Laurent Rineau 4297466869 add `--failure-expression` 
That avoids having to hardcode the assertion expression in the code
 2023-12-13 14:56:22 +01:00
Laurent Rineau 10fc714df9 add options to set the epsilon values (in particular to make them 0) 2023-12-13 14:45:58 +01:00
Laurent Rineau 5a628ec88a Merge pull request #7881 from afabri/Poisson-enable_structural_filtering-GF 
Poisson Surface Reconstruction: Enable Structural Filtering
 2023-12-11 13:56:08 +01:00
Laurent Rineau 3f42717b5a remove a spurious assertion 2023-12-08 16:05:07 +01:00
Laurent Rineau 934e65cd35 fix the assertion `v->nb_of_incident_constraints < 0` 2023-12-07 11:33:55 +01:00
Guillaume Damiand bd04b2a68d Remove space in doc 2023-12-06 17:01:34 +01:00
Laurent Rineau 7037df170e backup this script change 2023-12-06 14:58:08 +01:00
Guillaume Damiand 03ff679df4 doc draw: move advanced blocks 2023-12-05 14:10:25 +01:00
Laurent Rineau 6e613e08bb Better labels for Thingi10K test cases 2023-12-05 13:21:32 +01:00
Laurent Rineau 0c8697168f detect small distances 2023-12-05 13:20:46 +01:00
Guillaume Damiand df2b9ad172 doc draw pwh 2023-12-05 13:16:54 +01:00
Guillaume Damiand 5b7f499fc1 doc draw polygon 2023-12-05 12:58:30 +01:00
Guillaume Damiand d2f007d0df doc draw t3 2023-12-05 10:35:07 +01:00
Guillaume Damiand a204073c08 draw t3 2023-12-01 10:00:03 +01:00
Laurent Rineau 75a08ce746 Thingi10k: add a way to run a test case with merge_facets only 
Now CTest displays:
```
    Start 5393: execution   of  cdt_3_from_off --merge-facets Thingi10K_106789
    Start 5392: execution   of  cdt_3_from_off Thingi10K_106789
4/6 Test #5392: execution   of  cdt_3_from_off Thingi10K_106789 ..................***Not Run (Disabled)   0.00 sec
5/6 Test #5393: execution   of  cdt_3_from_off --merge-facets Thingi10K_106789 ...   Passed    0.10 sec
```
 2023-11-30 12:44:24 +01:00
Guillaume Damiand f8a487d9ef update dependencies 2023-11-29 18:12:09 +01:00
Laurent Rineau 95b83b1214 Merge pull request #7845 from puneetmatharu/patch-cgal-dont-override-build-testing 
Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject
 2023-11-29 17:22:54 +01:00
Guillaume Damiand 0655006622 Merge with master: now viewers use Qt6 2023-11-29 14:36:38 +01:00
Laurent Rineau 5fd8333a52 more debug messages 2023-11-28 19:51:24 +01:00
Andreas Fabri 8f8280ce34 Add structural filtering to Robust circumcenter traits 2023-11-23 19:37:23 +00:00
Sébastien Loriot 16de47d1e6 more fixes 2023-11-23 14:55:30 +01:00
Laurent Rineau 223454ab57 Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau 2023-11-16 16:01:01 +01:00
Laurent Rineau 5a5a5618f8 [_, inserter] = set.insert... Use .second instead 
That addresses a TODO from Jane's review.
 2023-11-16 11:40:42 +01:00
Laurent Rineau bbf2e8da31 simplify those lines 2023-11-16 11:38:29 +01:00
Sébastien Loriot cfac63f156 Merge remote-tracking branch 'cgal/master' into HEAD 2023-11-16 11:35:35 +01:00
Laurent Rineau a31fed66f1 construct_cavities: turn into vectors 2023-11-16 11:35:05 +01:00
Laurent Rineau 446d842586 insert_in_CDT_3: mirror facets directly 
Facets are pushed directly as mirror facets, on the border of the cavity
so that they are seen from the exterior of the cavity.

That avoids a copy of a vector of facets.
 2023-11-16 11:26:13 +01:00
Laurent Rineau 06e630287b another fix 
Now it seems to work!
 2023-11-16 10:32:14 +01:00
Laurent Rineau 1f75f30ab2 WIP: more fix 2023-11-16 10:32:14 +01:00
Laurent Rineau cc98a40424 WIP : fix 2023-11-16 10:32:14 +01:00
Laurent Rineau c9540b13c5 WIP: add insert_in_cdt_3 2023-11-16 10:32:14 +01:00
Laurent Rineau 4f50a45374 Extract inner_map_of_cavity to a member function 2023-11-16 10:32:14 +01:00
Laurent Rineau 569aeb33f4 fix a bug? 
The code review found that as a bug, but it never showed.
 2023-11-16 10:32:14 +01:00
Laurent Rineau 16171923c7 extract the lambda register_facet_to_be_constrained 
to a member function
 2023-11-16 10:32:14 +01:00
Laurent Rineau dc95d1ac59 fix typos (detected by spell-checker) 2023-11-16 10:32:14 +01:00
Laurent Rineau 0e34940a2d verify that CDT_3 works also with Epeck 2023-11-16 10:32:14 +01:00
Andreas Fabri 1dee4f8fff Fix conversion warning in T3 demo 2023-11-16 07:33:25 +00:00
Laurent Rineau 01f021d532 Merge pull request #7808 from janetournois/Triangulation_3-vertices_array-jtournois 
Triangulation_3 - add `vertices()` helper functions
 2023-11-15 15:44:22 +01:00
Jane Tournois 47477277d3 use initializer list 2023-11-13 13:58:05 +01:00
Jane Tournois 5974f2ca32 replace Vertex_triple by std::array<Vertex_handle, 3> 2023-11-13 13:48:05 +01:00
Andreas Fabri 97721a0c12 namespace fixes 2023-11-13 11:11:46 +00:00
Sébastien Loriot 2277013d84 replace boost::mpl::and_ 2023-11-10 16:19:26 +01:00
Laurent Rineau f46654ef8c more a function 
Now the two functions are adjacent:
- `try_to_insert_circumcenter_in_face_or_return_encroached_edge` and
- `insert_mid_point_in_constrained_edge`
 2023-11-09 19:39:47 +01:00
Laurent Rineau 255178644d `inner_map_of_cavity` uses `this` as const and nothing else 
That means it could be replaced by a const member function
 2023-11-09 19:38:46 +01:00
Laurent Rineau d1c513ac0d result of the review with Jane 2023-11-09 19:38:01 +01:00
Laurent Rineau 92aabb00ad use std::invoke (C++17) for IILE 
*Immediately Invoked Lambda Expression*

Now that CGAL can use C++17 , switch to `std::invoke`
that is more readable that the two small characters `()`
hidden somewhere a few lines below.

With `std::invoke`, we understand straight away that the lambda is
called immediately.

Ref:

https://www.cppstories.com/2016/11/iife-for-complex-initialization/
 2023-11-09 19:36:53 +01:00
Laurent Rineau 5997b70327 `triangulate_cavity` is a fct without side effect 
(but the debug outputs)
 2023-11-08 16:39:56 +01:00
Laurent Rineau 4d7a2fee64 Extract map_cavity_vertices_to_ambient_vertices 
- make it const,
 - and simplify the reuse of the API.
 2023-11-08 15:52:20 +01:00
Laurent Rineau 25de4ee6b7 Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau 2023-11-07 15:02:43 +01:00
Puneet Matharu 7944441068 Patch usage of BUILD_TESTING to handle the case that CGAL is a subproject. 2023-11-02 18:09:03 +00:00
Laurent Rineau 51627e3505 Merge remote-tracking branch 'cgal/master' into CGAL-Qt6-GF 
# Conflicts:
#	GraphicsView/demo/Bounding_volumes/CMakeLists.txt
 2023-11-01 20:59:44 +01:00
Sébastien Loriot ca0f9acbe0 Merge remote-tracking branch 'cgal/5.6.x-branch' 2023-10-25 17:43:16 +02:00
Jane Tournois 655a86a3f6 of/in 2023-10-24 12:32:41 +02:00
Laurent Rineau eb1ab88c04 Adapt triangulate_cavity 
that will allows its reuse by the function `insert(Point)`
 2023-10-24 11:39:58 +02:00
Guillaume Damiand 761fde02be add_in_graphics_scene -> add_to_graphics_scene; plus remove template parameter NumberType 2023-10-23 01:52:38 +02:00
Guillaume Damiand 6daa2a0c3b Graphics_scene is no more templated 2023-10-23 01:30:57 +02:00
Jane Tournois 6785c5cb7b document the order of vertices 2023-10-20 15:57:58 +02:00
Jane Tournois a9e1fb885c apply Monique's review 2023-10-20 15:09:31 +02:00
Jane Tournois 47e17d0a2c remove vertices(vertex) that is useless 2023-10-19 11:53:56 +02:00
Sébastien Loriot 9cefb1a481 fix out-of-bound warnings 2023-10-19 11:40:35 +02:00
Jane Tournois fbfcbe43d8 add documentation for the `vertices()` functions 2023-10-19 11:18:41 +02:00
Jane Tournois 152e473458 test vertices() helper functions 2023-10-19 11:13:47 +02:00
Jane Tournois c799051e2b add vertices() function for every dimension of simplex in T3 
returns a std::array of vertices
 2023-10-19 11:13:28 +02:00
Laurent Rineau afce4db325 commit more debug code 2023-10-17 18:06:18 +02:00
Laurent Rineau 5c633c2f0b extra assertion 
Check that the triangulation is still Delaunay after the conforming.
 2023-10-17 16:07:33 +02:00
Laurent Rineau 0186e9add9 add another option 
this one is to dump the input surface with the extra Steiner points
of the conforming.

And add a --help option as well.
 2023-10-17 16:05:35 +02:00
Laurent Rineau 762c8461f2 more options 2023-10-16 17:26:58 +02:00
Laurent Rineau 446ba43b25 factorize the handling of options 
so that I can introduce new ones more easily
 2023-10-16 09:51:06 +02:00
Laurent Rineau 4380273203 fix the number of added vertices in a cavity 2023-10-13 16:50:30 +02:00
Laurent Rineau d1e76c2099 fix typo 2023-10-13 16:48:48 +02:00
Laurent Rineau 265d3ba8fe reimplement brute_force_border_3_of_region 2023-10-04 16:16:33 +02:00
Laurent Rineau e3c132a675 --ratio: Adjust nb_of_bucket when only one face is skipped 2023-10-02 12:13:13 +02:00
Laurent Rineau 634992dc9b Replace ERROR by NOTE because those were not errors 2023-10-02 11:46:10 +02:00
Laurent Rineau 0f8539c0ad fix another bug in construct_Steiner_point 
@MaelRL This is the bug of Saddle-1CC.
 2023-10-02 11:45:47 +02:00
Laurent Rineau e910b9f550 remove m.collect_garbage(); 
`Surface_mesh::collect_garbage` uses swaps, and this it modifies the
order of elements of the mesh.
 2023-09-29 15:20:50 +02:00
Laurent Rineau 32903bd0fb allow the compilation with Epeck 2023-09-29 15:10:37 +02:00
Laurent Rineau a17542f29a with --ratio 0.1, iterate on all buckets in order 
... instead of applying random selection of buckets.
 2023-09-29 15:09:21 +02:00
Guillaume Damiand a5ee74cb66 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2023-09-29 08:36:37 +02:00
Guillaume Damiand 9f22d67ed0 Rename Graphic_storage in Graphics_scene (Andreas and Sebastien review) 2023-09-28 12:49:00 +02:00
Laurent Rineau c05d48b945 Add 4291 data sets from Thingi10K 
For the moment, I selected:
  - num_vertices < 10000 and
  - "solid"

As for the meaning of "solid", quoting Zhou, Qingnan, et al.
"Mesh arrangements for solid geometry."
ACM Transactions on Graphics (TOG) 35.4 (2016): 1-15.:
> Solid meshes are free of self-intersections, degenerate triangles
> or duplicate triangles, and their generalized winding number field
> is either zero or one.
 2023-09-28 12:46:39 +02:00
Laurent Rineau 21c4aec8b5 Allow to open more that OFF files 
The files are even repaired on the fiy.
 2023-09-28 12:38:18 +02:00
Guillaume Damiand fd115bd321 Rename Graphic_storare into Graphics_scene (Andreas and Sebastien review) 2023-09-28 11:06:53 +02:00
Guillaume Damiand 5cf89dadd9 Rename Drawing_functor in Graphics_scene_options (following Andreas and Sebastien review) 2023-09-28 09:51:12 +02:00
Laurent Rineau 7d35d64f1e add another selection of HexiCosPot 2023-09-26 17:46:36 +02:00
Laurent Rineau 2d87d4172d fix code when CGAL_NDEBUG or NDEBUG is defined 2023-09-26 15:34:17 +02:00
Laurent Rineau a1ac93b529 fix a warning 2023-09-26 15:33:44 +02:00
Laurent Rineau 38e836c963 oformat is in CGAL::IO:: 2023-09-26 13:00:20 +02:00
Laurent Rineau 0cdb022027 fix a bug in dimension 2 
There was a warning:
```
Triangulation_3/include/CGAL/Constrained_Delaunay_triangulation_3.h:1841:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
[build]  1841 |     } // dim 2
[build]       |     ^
```
and for once that was a warning about a real bug!
 2023-09-26 12:50:56 +02:00
Laurent Rineau c114e5d579 remove unused variable 2023-09-26 12:49:00 +02:00
Laurent Rineau 5b1248f910 unless CGAL_TRIANGULATION_CHECK_EXPENSIVE 2023-09-26 12:43:46 +02:00
Laurent Rineau 4be93760d1 try to workaround MSVC2022 error 
```
2>C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\include\type_traits(143,19): error C2338: static_assert failed: 'Calling declval is ill-formed, see N4917 22.2.6 [declval]/2.'
2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311): message : see reference to function template instantiation 'Segment &&std::declval<Segment>(void) noexcept' being compiled
2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311,57): message : see reference to function template instantiation 'std::vector<std::vector<Point,std::allocator<Point>>,std::allocator<std::vector<Point,std::allocator<Point>>>> segment_soup_to_polylines<_Ty&>(Range_of_segments)' being compiled
```
 2023-09-26 12:42:33 +02:00
Laurent Rineau 49836e1485 error message about unknown options 2023-09-26 12:41:22 +02:00
Laurent Rineau 091878f592 those debug function must be const 2023-09-25 18:58:35 +02:00
Laurent Rineau 6340d3508c insert the "bbox" iff cdt.dimension()==2 2023-09-25 18:56:38 +02:00
Laurent Rineau 49c52a00f0 better fix for cheese23 
The data set was not coplanar, but a few vertices were missing from the
initial CDT.
 2023-09-25 18:55:57 +02:00
Laurent Rineau 212228bf3a dump outputs with --merge-facets 2023-09-25 18:47:45 +02:00
Laurent Rineau 1b769b6e5b fix the bug of cheese23.off 
Actually, that was not a bug. The issue is that the simplex traverse
in 2D is currently buggy. With a bbox, that passes.
 2023-09-25 18:41:01 +02:00
Laurent Rineau 5bc5ec4f46 fix cheese18 --merge-facets 
The explanation of the bug:
`split_graph_into_polylines` can reverse the orientation of a polygon
 2023-09-25 17:58:03 +02:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Laurent Rineau 616cdfbc7a fix implementation of constraint_from_extremities 
It fixes `HexiCosPot-1.off`.
 2023-09-22 14:28:53 +02:00
Laurent Rineau 819f02d698 fix fandisk.off --merge-facets 2023-09-22 09:09:35 +02:00
Laurent Rineau aa09a28df8 Merge remote-tracking branch 'cgal/master' into STL_extension-Fix_Prevent_deref-GF 2023-09-19 16:22:49 +02:00
Laurent Rineau 412b9a5654 duplicate tests with --merge-facets 2023-09-15 16:48:58 +02:00
Laurent Rineau 28632f21fc Merge branch 'master' into CGAL-Qt6-GF 
# Conflicts:
#	Installation/CHANGES.md
 2023-09-14 17:40:05 +02:00
Laurent Rineau 2f6d51b49b Remove a few occurrences of CGAL_Qt5 
... and replace by CGAL_Qt6
 2023-09-14 16:33:20 +02:00
Laurent Rineau 09a4ac1ad7 cosmetic changes 2023-09-14 14:39:45 +02:00
Laurent Rineau 188f99ff97 code to detriangulate facets 2023-09-13 09:25:04 +02:00
Laurent Rineau 733d9ed8b7 handle a few program options 2023-09-12 17:51:30 +02:00
Nicolas Saillant 0d7280ea63 CMakeLists updates for Qt6 2023-09-11 16:10:20 +02:00
Laurent Rineau 3b77eaac1c WIP: preliminary work on detriangulate 2023-09-07 12:53:39 +02:00
Laurent Rineau 46923342ad Merge pull request #7576 from albert-github/feature/issue_7395 
issue #7395 Improvement of layout of model relations

# Conflicts:
#	Kernel_23/doc/Kernel_23/CGAL/Vector_2.h
 2023-09-07 10:48:34 +02:00
Nicolas Saillant 0303b8dfd5 Update CMakeLists for QT6 2023-09-05 15:58:43 +02:00
Laurent Rineau 6234786dd9 is_valid: test all cells before return false 2023-09-04 11:11:23 +02:00
Laurent Rineau 6070f6e01a tweak debug macros 2023-08-31 18:23:48 +02:00
Laurent Rineau fc0cb34e64 more verbose is_valid 2023-08-31 12:06:33 +02:00
Laurent Rineau cf73165563 debug msg 2023-08-31 12:04:53 +02:00
Laurent Rineau f631d1eefe Use a centroid 
That ensures that the Steiner point is inside the constrained polygon.
 2023-08-31 11:59:25 +02:00
Laurent Rineau e8c6d15652 implement edge flip for regions of two triangles 2023-08-31 11:51:14 +02:00
Guillaume Damiand 467e55f10d Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2023-08-28 14:38:58 +02:00
Sébastien Loriot 608d0c81c4 use a macro 2023-08-24 14:56:48 +02:00
Sébastien Loriot 68bc244d02 Merge remote-tracking branch 'cgal/master' into HEAD 2023-08-24 14:14:12 +02:00
Sébastien Loriot 28f904f4e2 Merge remote-tracking branch 'cgal/master' 2023-08-15 07:16:14 +02:00
albert-github 0ce82c0bd5 Better showing of `#include` 
Getting a better (and consistent) output for the include file to be used with some functions.
Normally `#include` are sown as in a typewrite font, but the `#include` in these cases were shown in a code block way.
 2023-08-13 18:22:07 +02:00
Laurent Rineau 4d132faedd extract lambdas iinto proper member functions 2023-08-03 16:42:28 +02:00
Laurent Rineau 420a3789c5 fix the detection of encroached constrained edge in the face 2023-08-02 18:24:22 +02:00
Laurent Rineau 6f965038fa add a new assertion 2023-08-02 18:16:18 +02:00
Laurent Rineau db53aedd08 extend the testsuite 2023-08-02 18:14:50 +02:00
Laurent Rineau 9620c88839 Use the right CDT::is_valid function 2023-08-02 18:12:08 +02:00
Laurent Rineau 6c06dcbf34 change verbosity level of debug messages 2023-08-02 17:01:31 +02:00
Laurent Rineau 7df2963397 fix formatting 2023-08-02 16:03:40 +02:00
Laurent Rineau 07cfd82a84 add const/non_const ref to the CDT_2 2023-08-02 16:02:53 +02:00
Laurent Rineau e4e94d6cdb merge two contiguous `if CGAL_DEBUG_CDT_3` 2023-08-02 11:31:18 +02:00
Laurent Rineau 513efe6176 Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2023-08-01 16:07:57 +02:00
Laurent Rineau b5c8557797 fix Steiner points on edges 
for the conforming

(during the review session with Jane)
 2023-08-01 15:49:13 +02:00
Laurent Rineau cf0fd18715 add CGAL/cdt_debug_ui.h 2023-08-01 10:21:04 +02:00
Laurent Rineau 28384ddadb track the 3D facet correspind to CDT_2's facets 2023-08-01 09:31:27 +02:00
Laurent Rineau 743f974679 add a CDT_3::is_valid member function 2023-08-01 09:28:59 +02:00
Laurent Rineau ba7b769f8e insert_impl_do_not_split 2023-08-01 09:28:26 +02:00
Andreas Fabri 64d840f978 Reduced data set with segfault (Release, not Debug) 2023-07-28 07:59:21 +01:00
Laurent Rineau 87e76c3444 add an assertion at the end 2023-07-27 17:32:40 +02:00
Laurent Rineau 8839348d51 Try to be quiet 2023-07-27 14:48:32 +02:00
Laurent Rineau de2d9165cd fix the search process for a minimal input 2023-07-27 14:48:25 +02:00
Laurent Rineau bf28cd765a better handling of "PLC error": pass to next face if possible 2023-07-27 14:28:42 +02:00
Andreas Fabri 8e3bcc10b7 Add a data set where I get a segfault 2023-07-27 11:50:17 +01:00
Laurent Rineau af9b9df2eb fix bug in search_first_intersection 
- now segments touching the border are ignored
- and all edges of the border are tested until one intersection is found
 2023-07-27 11:43:28 +02:00
Laurent Rineau 318080105a not sure if that is important 2023-07-27 11:43:28 +02:00
Laurent Rineau 787458ce01 add a comment about CDT_3_face_index 2023-07-27 11:20:03 +02:00
Laurent Rineau fc2b8d8548 Merge pull request #7611 from lrineau/Triangulation_3-fix_traverser_testsuite_cpp17-lrineau 
Triangulation_3: the testsuite of the simplex traverser needs C++17
 2023-07-26 17:34:31 +02:00
Laurent Rineau 0ca574172a Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2023-07-26 11:05:34 +02:00
Andreas Fabri 09214a903d Merge branch 'Triangulation_3-CDT_3-lrineau' of github.com:lrineau/cgal into Triangulation_3-CDT_3-lrineau 2023-07-26 10:02:49 +01:00
Andreas Fabri aa4c2ef944 Reduce to 3 faces 2023-07-26 10:02:28 +01:00
Laurent Rineau 41b46baf5b Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2023-07-25 18:46:07 +02:00
Laurent Rineau 9188bfbd63 fix a bug 
A classical bug: in the conflict zone of a vertex about to be inserted,
the "constrained" faces must be marked unconstrained *before*
the insertion.
 2023-07-25 18:44:56 +02:00
Jane Tournois facd881c19 replace assertion by assume 2023-07-25 18:03:15 +02:00
Jane Tournois 184b00a030 in Release mode with msvc, c, i and j were not initialized 2023-07-25 17:50:36 +02:00
Jane Tournois 676a7494ac fix maybe unused warning and the use of cpp23 2023-07-25 16:49:50 +02:00
Laurent Rineau 2410bbfa3c Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2023-07-25 16:25:07 +02:00
Laurent Rineau 4670375da1 Add CDT::set_facet_constrained 
That allows to wrap the call with additional verifications
 2023-07-25 16:25:00 +02:00
Laurent Rineau 5987325bf0 add export_facets_to_surface_mesh 2023-07-25 16:24:04 +02:00
Laurent Rineau 9fde28bd34 less debug output with -DCGAL_DEBUG_CDT_3=1 2023-07-25 16:23:14 +02:00
Laurent Rineau 9c69c39764 Fix when CGAL_DEBUG_CDT_3 is not defined 2023-07-25 16:21:26 +02:00
Andreas Fabri 84b06d77e9 Reduced to 9 faces (and many isolated vertices) 2023-07-25 10:06:52 +01:00
Andreas Fabri 79b0b861d6 Still relatively large, but with another error message 2023-07-25 09:19:19 +01:00
Andreas Fabri 7085d7f6bd A new assertion 2023-07-25 09:08:52 +01:00
Laurent Rineau f9a094b4bb Code to minimize input data for bugs 2023-07-24 16:18:29 +02:00
Laurent Rineau 4000758907 bug fix; fix incomplete cavities 2023-07-24 16:14:52 +02:00
Andreas Fabri 98ad3f6b93 Get an assertion 2023-07-24 09:30:41 +01:00
Laurent Rineau 2ab6c8bffa less debug 2023-07-21 16:08:34 +02:00
Laurent Rineau 950cf9f025 debug dump the result of conforming edges 2023-07-21 16:00:05 +02:00
Laurent Rineau dd63543cd7 API changes 2023-07-21 15:58:17 +02:00
Laurent Rineau b03944fc3f insert all input vertices at the beginning 2023-07-21 15:36:45 +02:00
Laurent Rineau f799769361 remove the height point on the box 
They make insert more Steiner vertices.
 2023-07-21 15:36:09 +02:00
Laurent Rineau 15968e2d49 Need C++17 
`test_simplex_iterator_3.cpp` and
`test_segment_simplex_traverser_3.cpp` require C++17.
 2023-07-20 10:54:02 +02:00
Laurent Rineau 24b9d126da Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau 
# Conflicts:
#	STL_Extension/include/CGAL/iterator.h
#	Triangulation_3/test/Triangulation_3/CMakeLists.txt
 2023-07-18 15:37:52 +02:00
albert-github ad41766454 issue #7395 Improvement of layout of model relations 
Corrected `cgalModels` to `cgalHasModes` inside `cgalHasNodelsBegin` / `cgalHasModelsEnd`
 2023-07-18 13:23:37 +02:00
Mael c6fd1d0316
Merge branch 'master' into CGAL-Qt6-GF 2023-07-18 10:49:58 +02:00
albert-github de3ba0f47c Merge remote-tracking branch 'upstream/master' into feature/issue_7395 2023-07-17 10:17:34 +02:00
albert-github 4e5578d469 issue #7395 Improvement of layout of model relations 
- based on review
 2023-07-15 13:12:15 +02:00
albert-github a0320dd7b4 Merge branch 'master' into feature/issue_7395 
# Conflicts:
#	Polyhedron/doc/Polyhedron/Concepts/PolyhedronItems_3.h
 2023-07-13 10:33:18 +02:00
Laurent Rineau d10e9387c2 Merge branch 'master' into CGAL-add_missing_test 
# Conflicts:
#	STL_Extension/test/STL_Extension/test_skiplist.cpp
 2023-07-12 15:48:42 +02:00
Laurent Rineau 4a2c7a668d Merge pull request #7571 from albert-github/feature/issue_7454 
issue #7454 Consistency of BigO notations
 2023-07-12 15:29:56 +02:00
Laurent Rineau 0e814f3a93 Merge pull request #7584 from sloriot/T3-fix_warnings 
fix unused variable warnings
 2023-07-12 15:29:47 +02:00
Laurent Rineau 9bbebd4468 Merge pull request #7584 from sloriot/T3-fix_warnings 
fix unused variable warnings
 2023-07-12 15:23:47 +02:00
Sebastien Loriot 57b7edb6a3
Apply suggestions from code review 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2023-07-12 10:41:44 +02:00
Laurent Rineau c423f550e8 debug info 2023-07-11 17:15:45 +02:00
Laurent Rineau a7511068ef fix warning 2023-07-11 17:15:27 +02:00
Laurent Rineau 38d7284522 wip API for several polygons at once 2023-07-11 16:31:00 +02:00
Laurent Rineau 355b01b859 add vertex type 
remove `v->original_point`
 2023-07-11 16:25:56 +02:00
Laurent Rineau 54cd55b3f8 work with flat data: extend the bbox 2023-07-11 15:07:19 +02:00
Laurent Rineau da9f6421ed debug info 2023-07-11 15:06:14 +02:00
Laurent Rineau d1a71d0fec change the creation of Steiner vertices 2023-07-11 15:02:52 +02:00
Sébastien Loriot 125542eb62 Merge remote-tracking branch 'cgal/master' 2023-07-11 12:59:21 +02:00
Sébastien Loriot 560186b432 fix one more warning 2023-07-10 13:25:38 +02:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations 
- Completed the cgalModels part
 2023-07-09 12:43:36 +02:00
Sébastien Loriot 4e6fe0c561 fix unused variable warnings 2023-07-06 18:06:03 +02:00
albert-github ee2a55279d issue #7395 Improvement of layout of model relations 
- Completed the cgalHasModel part
- corrected spelling of `Has Model` and `Is Model Of` to `Has model` and `Is model of`
 2023-07-06 17:35:34 +02:00
Laurent Rineau 04077e9f4f Merge pull request #7535 from lrineau/Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 
fix simplex traverser for CGAL 5.6
 2023-07-05 16:32:36 +02:00
Sébastien Loriot 68813c5c63 Merge pull request #7403 from sloriot/CGAL-replace_boost_by_std 
Replace boost by std
 2023-07-05 11:08:36 +02:00
Laurent Rineau bb6eb6f711 fix the "cheesy" bug 
Now the test passes with `cheese.off`, in 205.41 sec
in `RelWithDebInfo` mode
 2023-07-04 22:59:09 +02:00
albert-github b3af96caa1 issue #7454 Consistency of BigO notations 
Create `cgalBigO` marco and used it.
(`The macro `cgalBigOLarge` is for special situations where we need bigger round brackets)
 2023-07-04 16:23:14 +02:00
Laurent Rineau e27f84822a add a test 2023-06-29 17:03:16 +02:00
Laurent Rineau fcc574c24c better debug messages 2023-06-29 17:03:16 +02:00
Laurent Rineau e0b386d3f4 fix shameful bug 
Now the CDT_3 testsuite passes, cheese.of as well.

... it was really a shameful bug: a point projection on a segment!
 2023-06-29 17:03:16 +02:00
Laurent Rineau ba5a32361e fix previous commit (warning) 2023-06-29 17:03:03 +02:00
Andreas Fabri 00b540d791 Fix precomputed data 2023-06-29 15:34:03 +01:00
Laurent Rineau 15618b2916 fix CDT_3 
almost done
 2023-06-28 20:21:36 +02:00
Laurent Rineau 4b18c7208a fix warnings 2023-06-27 17:29:37 +02:00
Sébastien Loriot efd8b2d38b add more missing tests 2023-06-27 11:18:20 +02:00
Guillaume Damiand fe23441eab Merge master 2023-06-26 14:42:33 +02:00
Laurent Rineau a85ce74720 Merge branch 'Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6' into Triangulation_3-CDT_3-lrineau 2023-06-22 15:28:48 +02:00
Guillaume Damiand 7da9812bda Rename graphic_buffer into graphic_storage. 2023-06-22 15:18:34 +02:00
Sébastien Loriot dfc386d65b Merge branch 'master' into HEAD 2023-06-22 14:05:45 +02:00