songsenand
/
cgal
mirror of https://github.com/CGAL/cgal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
113,740 Commits 3 Branches 156 Tags 974 MiB
Commit Graph

2844 Commits

Author SHA1 Message Date
Jane Tournois c799051e2b add vertices() function for every dimension of simplex in T3 
returns a std::array of vertices
 2023-10-19 11:13:28 +02:00
Laurent Rineau afce4db325 commit more debug code 2023-10-17 18:06:18 +02:00
Laurent Rineau 5c633c2f0b extra assertion 
Check that the triangulation is still Delaunay after the conforming.
 2023-10-17 16:07:33 +02:00
Laurent Rineau 0186e9add9 add another option 
this one is to dump the input surface with the extra Steiner points
of the conforming.

And add a --help option as well.
 2023-10-17 16:05:35 +02:00
Laurent Rineau 762c8461f2 more options 2023-10-16 17:26:58 +02:00
Laurent Rineau 446ba43b25 factorize the handling of options 
so that I can introduce new ones more easily
 2023-10-16 09:51:06 +02:00
Laurent Rineau 4380273203 fix the number of added vertices in a cavity 2023-10-13 16:50:30 +02:00
Laurent Rineau d1e76c2099 fix typo 2023-10-13 16:48:48 +02:00
Laurent Rineau 265d3ba8fe reimplement brute_force_border_3_of_region 2023-10-04 16:16:33 +02:00
Laurent Rineau e3c132a675 --ratio: Adjust nb_of_bucket when only one face is skipped 2023-10-02 12:13:13 +02:00
Laurent Rineau 634992dc9b Replace ERROR by NOTE because those were not errors 2023-10-02 11:46:10 +02:00
Laurent Rineau 0f8539c0ad fix another bug in construct_Steiner_point 
@MaelRL This is the bug of Saddle-1CC.
 2023-10-02 11:45:47 +02:00
Laurent Rineau e910b9f550 remove m.collect_garbage(); 
`Surface_mesh::collect_garbage` uses swaps, and this it modifies the
order of elements of the mesh.
 2023-09-29 15:20:50 +02:00
Laurent Rineau 32903bd0fb allow the compilation with Epeck 2023-09-29 15:10:37 +02:00
Laurent Rineau a17542f29a with --ratio 0.1, iterate on all buckets in order 
... instead of applying random selection of buckets.
 2023-09-29 15:09:21 +02:00
Guillaume Damiand a5ee74cb66 Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2023-09-29 08:36:37 +02:00
Guillaume Damiand 9f22d67ed0 Rename Graphic_storage in Graphics_scene (Andreas and Sebastien review) 2023-09-28 12:49:00 +02:00
Laurent Rineau c05d48b945 Add 4291 data sets from Thingi10K 
For the moment, I selected:
  - num_vertices < 10000 and
  - "solid"

As for the meaning of "solid", quoting Zhou, Qingnan, et al.
"Mesh arrangements for solid geometry."
ACM Transactions on Graphics (TOG) 35.4 (2016): 1-15.:
> Solid meshes are free of self-intersections, degenerate triangles
> or duplicate triangles, and their generalized winding number field
> is either zero or one.
 2023-09-28 12:46:39 +02:00
Laurent Rineau 21c4aec8b5 Allow to open more that OFF files 
The files are even repaired on the fiy.
 2023-09-28 12:38:18 +02:00
Guillaume Damiand fd115bd321 Rename Graphic_storare into Graphics_scene (Andreas and Sebastien review) 2023-09-28 11:06:53 +02:00
Guillaume Damiand 5cf89dadd9 Rename Drawing_functor in Graphics_scene_options (following Andreas and Sebastien review) 2023-09-28 09:51:12 +02:00
Laurent Rineau 7d35d64f1e add another selection of HexiCosPot 2023-09-26 17:46:36 +02:00
Laurent Rineau 2d87d4172d fix code when CGAL_NDEBUG or NDEBUG is defined 2023-09-26 15:34:17 +02:00
Laurent Rineau a1ac93b529 fix a warning 2023-09-26 15:33:44 +02:00
Laurent Rineau 38e836c963 oformat is in CGAL::IO:: 2023-09-26 13:00:20 +02:00
Laurent Rineau 0cdb022027 fix a bug in dimension 2 
There was a warning:
```
Triangulation_3/include/CGAL/Constrained_Delaunay_triangulation_3.h:1841:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
[build]  1841 |     } // dim 2
[build]       |     ^
```
and for once that was a warning about a real bug!
 2023-09-26 12:50:56 +02:00
Laurent Rineau c114e5d579 remove unused variable 2023-09-26 12:49:00 +02:00
Laurent Rineau 5b1248f910 unless CGAL_TRIANGULATION_CHECK_EXPENSIVE 2023-09-26 12:43:46 +02:00
Laurent Rineau 4be93760d1 try to workaround MSVC2022 error 
```
2>C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\include\type_traits(143,19): error C2338: static_assert failed: 'Calling declval is ill-formed, see N4917 22.2.6 [declval]/2.'
2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311): message : see reference to function template instantiation 'Segment &&std::declval<Segment>(void) noexcept' being compiled
2>C:\GitHub\cgal\Triangulation_3\test\Triangulation_3\cdt_3_from_off.cpp(311,57): message : see reference to function template instantiation 'std::vector<std::vector<Point,std::allocator<Point>>,std::allocator<std::vector<Point,std::allocator<Point>>>> segment_soup_to_polylines<_Ty&>(Range_of_segments)' being compiled
```
 2023-09-26 12:42:33 +02:00
Laurent Rineau 49836e1485 error message about unknown options 2023-09-26 12:41:22 +02:00
Laurent Rineau 091878f592 those debug function must be const 2023-09-25 18:58:35 +02:00
Laurent Rineau 6340d3508c insert the "bbox" iff cdt.dimension()==2 2023-09-25 18:56:38 +02:00
Laurent Rineau 49c52a00f0 better fix for cheese23 
The data set was not coplanar, but a few vertices were missing from the
initial CDT.
 2023-09-25 18:55:57 +02:00
Laurent Rineau 212228bf3a dump outputs with --merge-facets 2023-09-25 18:47:45 +02:00
Laurent Rineau 1b769b6e5b fix the bug of cheese23.off 
Actually, that was not a bug. The issue is that the simplex traverse
in 2D is currently buggy. With a bbox, that passes.
 2023-09-25 18:41:01 +02:00
Laurent Rineau 5bc5ec4f46 fix cheese18 --merge-facets 
The explanation of the bug:
`split_graph_into_polylines` can reverse the orientation of a polygon
 2023-09-25 17:58:03 +02:00
Sébastien Loriot 8700394122 boost::mpl::if_ -> std::conditional 2023-09-24 22:57:20 +02:00
Laurent Rineau 616cdfbc7a fix implementation of constraint_from_extremities 
It fixes `HexiCosPot-1.off`.
 2023-09-22 14:28:53 +02:00
Laurent Rineau 819f02d698 fix fandisk.off --merge-facets 2023-09-22 09:09:35 +02:00
Laurent Rineau aa09a28df8 Merge remote-tracking branch 'cgal/master' into STL_extension-Fix_Prevent_deref-GF 2023-09-19 16:22:49 +02:00
Laurent Rineau 412b9a5654 duplicate tests with --merge-facets 2023-09-15 16:48:58 +02:00
Laurent Rineau 28632f21fc Merge branch 'master' into CGAL-Qt6-GF 
# Conflicts:
#	Installation/CHANGES.md
 2023-09-14 17:40:05 +02:00
Laurent Rineau 2f6d51b49b Remove a few occurrences of CGAL_Qt5 
... and replace by CGAL_Qt6
 2023-09-14 16:33:20 +02:00
Laurent Rineau 09a4ac1ad7 cosmetic changes 2023-09-14 14:39:45 +02:00
Laurent Rineau 188f99ff97 code to detriangulate facets 2023-09-13 09:25:04 +02:00
Laurent Rineau 733d9ed8b7 handle a few program options 2023-09-12 17:51:30 +02:00
Nicolas Saillant 0d7280ea63 CMakeLists updates for Qt6 2023-09-11 16:10:20 +02:00
Laurent Rineau 3b77eaac1c WIP: preliminary work on detriangulate 2023-09-07 12:53:39 +02:00
Laurent Rineau 46923342ad Merge pull request #7576 from albert-github/feature/issue_7395 
issue #7395 Improvement of layout of model relations

# Conflicts:
#	Kernel_23/doc/Kernel_23/CGAL/Vector_2.h
 2023-09-07 10:48:34 +02:00
Nicolas Saillant 0303b8dfd5 Update CMakeLists for QT6 2023-09-05 15:58:43 +02:00
Laurent Rineau 6234786dd9 is_valid: test all cells before return false 2023-09-04 11:11:23 +02:00
Laurent Rineau 6070f6e01a tweak debug macros 2023-08-31 18:23:48 +02:00
Laurent Rineau fc0cb34e64 more verbose is_valid 2023-08-31 12:06:33 +02:00
Laurent Rineau cf73165563 debug msg 2023-08-31 12:04:53 +02:00
Laurent Rineau f631d1eefe Use a centroid 
That ensures that the Steiner point is inside the constrained polygon.
 2023-08-31 11:59:25 +02:00
Laurent Rineau e8c6d15652 implement edge flip for regions of two triangles 2023-08-31 11:51:14 +02:00
Guillaume Damiand 467e55f10d Merge branch 'master' into gsoc2022-EBVs-Mostafa-ashraf19 2023-08-28 14:38:58 +02:00
Sébastien Loriot 608d0c81c4 use a macro 2023-08-24 14:56:48 +02:00
Sébastien Loriot 68bc244d02 Merge remote-tracking branch 'cgal/master' into HEAD 2023-08-24 14:14:12 +02:00
Sébastien Loriot 28f904f4e2 Merge remote-tracking branch 'cgal/master' 2023-08-15 07:16:14 +02:00
albert-github 0ce82c0bd5 Better showing of `#include` 
Getting a better (and consistent) output for the include file to be used with some functions.
Normally `#include` are sown as in a typewrite font, but the `#include` in these cases were shown in a code block way.
 2023-08-13 18:22:07 +02:00
Laurent Rineau 4d132faedd extract lambdas iinto proper member functions 2023-08-03 16:42:28 +02:00
Laurent Rineau 420a3789c5 fix the detection of encroached constrained edge in the face 2023-08-02 18:24:22 +02:00
Laurent Rineau 6f965038fa add a new assertion 2023-08-02 18:16:18 +02:00
Laurent Rineau db53aedd08 extend the testsuite 2023-08-02 18:14:50 +02:00
Laurent Rineau 9620c88839 Use the right CDT::is_valid function 2023-08-02 18:12:08 +02:00
Laurent Rineau 6c06dcbf34 change verbosity level of debug messages 2023-08-02 17:01:31 +02:00
Laurent Rineau 7df2963397 fix formatting 2023-08-02 16:03:40 +02:00
Laurent Rineau 07cfd82a84 add const/non_const ref to the CDT_2 2023-08-02 16:02:53 +02:00
Laurent Rineau e4e94d6cdb merge two contiguous `if CGAL_DEBUG_CDT_3` 2023-08-02 11:31:18 +02:00
Laurent Rineau 513efe6176 Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2023-08-01 16:07:57 +02:00
Laurent Rineau b5c8557797 fix Steiner points on edges 
for the conforming

(during the review session with Jane)
 2023-08-01 15:49:13 +02:00
Laurent Rineau cf0fd18715 add CGAL/cdt_debug_ui.h 2023-08-01 10:21:04 +02:00
Laurent Rineau 28384ddadb track the 3D facet correspind to CDT_2's facets 2023-08-01 09:31:27 +02:00
Laurent Rineau 743f974679 add a CDT_3::is_valid member function 2023-08-01 09:28:59 +02:00
Laurent Rineau ba7b769f8e insert_impl_do_not_split 2023-08-01 09:28:26 +02:00
Andreas Fabri 64d840f978 Reduced data set with segfault (Release, not Debug) 2023-07-28 07:59:21 +01:00
Laurent Rineau 87e76c3444 add an assertion at the end 2023-07-27 17:32:40 +02:00
Laurent Rineau 8839348d51 Try to be quiet 2023-07-27 14:48:32 +02:00
Laurent Rineau de2d9165cd fix the search process for a minimal input 2023-07-27 14:48:25 +02:00
Laurent Rineau bf28cd765a better handling of "PLC error": pass to next face if possible 2023-07-27 14:28:42 +02:00
Andreas Fabri 8e3bcc10b7 Add a data set where I get a segfault 2023-07-27 11:50:17 +01:00
Laurent Rineau af9b9df2eb fix bug in search_first_intersection 
- now segments touching the border are ignored
- and all edges of the border are tested until one intersection is found
 2023-07-27 11:43:28 +02:00
Laurent Rineau 318080105a not sure if that is important 2023-07-27 11:43:28 +02:00
Laurent Rineau 787458ce01 add a comment about CDT_3_face_index 2023-07-27 11:20:03 +02:00
Laurent Rineau fc2b8d8548 Merge pull request #7611 from lrineau/Triangulation_3-fix_traverser_testsuite_cpp17-lrineau 
Triangulation_3: the testsuite of the simplex traverser needs C++17
 2023-07-26 17:34:31 +02:00
Laurent Rineau 0ca574172a Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2023-07-26 11:05:34 +02:00
Andreas Fabri 09214a903d Merge branch 'Triangulation_3-CDT_3-lrineau' of github.com:lrineau/cgal into Triangulation_3-CDT_3-lrineau 2023-07-26 10:02:49 +01:00
Andreas Fabri aa4c2ef944 Reduce to 3 faces 2023-07-26 10:02:28 +01:00
Laurent Rineau 41b46baf5b Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2023-07-25 18:46:07 +02:00
Laurent Rineau 9188bfbd63 fix a bug 
A classical bug: in the conflict zone of a vertex about to be inserted,
the "constrained" faces must be marked unconstrained *before*
the insertion.
 2023-07-25 18:44:56 +02:00
Jane Tournois facd881c19 replace assertion by assume 2023-07-25 18:03:15 +02:00
Jane Tournois 184b00a030 in Release mode with msvc, c, i and j were not initialized 2023-07-25 17:50:36 +02:00
Jane Tournois 676a7494ac fix maybe unused warning and the use of cpp23 2023-07-25 16:49:50 +02:00
Laurent Rineau 2410bbfa3c Merge remote-tracking branch 'refs/remotes/lrineau/Triangulation_3-CDT_3-lrineau' into Triangulation_3-CDT_3-lrineau 2023-07-25 16:25:07 +02:00
Laurent Rineau 4670375da1 Add CDT::set_facet_constrained 
That allows to wrap the call with additional verifications
 2023-07-25 16:25:00 +02:00
Laurent Rineau 5987325bf0 add export_facets_to_surface_mesh 2023-07-25 16:24:04 +02:00
Laurent Rineau 9fde28bd34 less debug output with -DCGAL_DEBUG_CDT_3=1 2023-07-25 16:23:14 +02:00
Laurent Rineau 9c69c39764 Fix when CGAL_DEBUG_CDT_3 is not defined 2023-07-25 16:21:26 +02:00
Andreas Fabri 84b06d77e9 Reduced to 9 faces (and many isolated vertices) 2023-07-25 10:06:52 +01:00
Andreas Fabri 79b0b861d6 Still relatively large, but with another error message 2023-07-25 09:19:19 +01:00
Andreas Fabri 7085d7f6bd A new assertion 2023-07-25 09:08:52 +01:00
Laurent Rineau f9a094b4bb Code to minimize input data for bugs 2023-07-24 16:18:29 +02:00
Laurent Rineau 4000758907 bug fix; fix incomplete cavities 2023-07-24 16:14:52 +02:00
Andreas Fabri 98ad3f6b93 Get an assertion 2023-07-24 09:30:41 +01:00
Laurent Rineau 2ab6c8bffa less debug 2023-07-21 16:08:34 +02:00
Laurent Rineau 950cf9f025 debug dump the result of conforming edges 2023-07-21 16:00:05 +02:00
Laurent Rineau dd63543cd7 API changes 2023-07-21 15:58:17 +02:00
Laurent Rineau b03944fc3f insert all input vertices at the beginning 2023-07-21 15:36:45 +02:00
Laurent Rineau f799769361 remove the height point on the box 
They make insert more Steiner vertices.
 2023-07-21 15:36:09 +02:00
Laurent Rineau 15968e2d49 Need C++17 
`test_simplex_iterator_3.cpp` and
`test_segment_simplex_traverser_3.cpp` require C++17.
 2023-07-20 10:54:02 +02:00
Laurent Rineau 24b9d126da Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau 
# Conflicts:
#	STL_Extension/include/CGAL/iterator.h
#	Triangulation_3/test/Triangulation_3/CMakeLists.txt
 2023-07-18 15:37:52 +02:00
albert-github ad41766454 issue #7395 Improvement of layout of model relations 
Corrected `cgalModels` to `cgalHasModes` inside `cgalHasNodelsBegin` / `cgalHasModelsEnd`
 2023-07-18 13:23:37 +02:00
Mael c6fd1d0316
Merge branch 'master' into CGAL-Qt6-GF 2023-07-18 10:49:58 +02:00
albert-github de3ba0f47c Merge remote-tracking branch 'upstream/master' into feature/issue_7395 2023-07-17 10:17:34 +02:00
albert-github 4e5578d469 issue #7395 Improvement of layout of model relations 
- based on review
 2023-07-15 13:12:15 +02:00
albert-github a0320dd7b4 Merge branch 'master' into feature/issue_7395 
# Conflicts:
#	Polyhedron/doc/Polyhedron/Concepts/PolyhedronItems_3.h
 2023-07-13 10:33:18 +02:00
Laurent Rineau d10e9387c2 Merge branch 'master' into CGAL-add_missing_test 
# Conflicts:
#	STL_Extension/test/STL_Extension/test_skiplist.cpp
 2023-07-12 15:48:42 +02:00
Laurent Rineau 4a2c7a668d Merge pull request #7571 from albert-github/feature/issue_7454 
issue #7454 Consistency of BigO notations
 2023-07-12 15:29:56 +02:00
Laurent Rineau 0e814f3a93 Merge pull request #7584 from sloriot/T3-fix_warnings 
fix unused variable warnings
 2023-07-12 15:29:47 +02:00
Laurent Rineau 9bbebd4468 Merge pull request #7584 from sloriot/T3-fix_warnings 
fix unused variable warnings
 2023-07-12 15:23:47 +02:00
Sebastien Loriot 57b7edb6a3
Apply suggestions from code review 
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
 2023-07-12 10:41:44 +02:00
Laurent Rineau c423f550e8 debug info 2023-07-11 17:15:45 +02:00
Laurent Rineau a7511068ef fix warning 2023-07-11 17:15:27 +02:00
Laurent Rineau 38d7284522 wip API for several polygons at once 2023-07-11 16:31:00 +02:00
Laurent Rineau 355b01b859 add vertex type 
remove `v->original_point`
 2023-07-11 16:25:56 +02:00
Laurent Rineau 54cd55b3f8 work with flat data: extend the bbox 2023-07-11 15:07:19 +02:00
Laurent Rineau da9f6421ed debug info 2023-07-11 15:06:14 +02:00
Laurent Rineau d1a71d0fec change the creation of Steiner vertices 2023-07-11 15:02:52 +02:00
Sébastien Loriot 125542eb62 Merge remote-tracking branch 'cgal/master' 2023-07-11 12:59:21 +02:00
Sébastien Loriot 560186b432 fix one more warning 2023-07-10 13:25:38 +02:00
albert-github 301728a8a9 issue #7395 Improvement of layout of model relations 
- Completed the cgalModels part
 2023-07-09 12:43:36 +02:00
Sébastien Loriot 4e6fe0c561 fix unused variable warnings 2023-07-06 18:06:03 +02:00
albert-github ee2a55279d issue #7395 Improvement of layout of model relations 
- Completed the cgalHasModel part
- corrected spelling of `Has Model` and `Is Model Of` to `Has model` and `Is model of`
 2023-07-06 17:35:34 +02:00
Laurent Rineau 04077e9f4f Merge pull request #7535 from lrineau/Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 
fix simplex traverser for CGAL 5.6
 2023-07-05 16:32:36 +02:00
Sébastien Loriot 68813c5c63 Merge pull request #7403 from sloriot/CGAL-replace_boost_by_std 
Replace boost by std
 2023-07-05 11:08:36 +02:00
Laurent Rineau bb6eb6f711 fix the "cheesy" bug 
Now the test passes with `cheese.off`, in 205.41 sec
in `RelWithDebInfo` mode
 2023-07-04 22:59:09 +02:00
albert-github b3af96caa1 issue #7454 Consistency of BigO notations 
Create `cgalBigO` marco and used it.
(`The macro `cgalBigOLarge` is for special situations where we need bigger round brackets)
 2023-07-04 16:23:14 +02:00
Laurent Rineau e27f84822a add a test 2023-06-29 17:03:16 +02:00
Laurent Rineau fcc574c24c better debug messages 2023-06-29 17:03:16 +02:00
Laurent Rineau e0b386d3f4 fix shameful bug 
Now the CDT_3 testsuite passes, cheese.of as well.

... it was really a shameful bug: a point projection on a segment!
 2023-06-29 17:03:16 +02:00
Laurent Rineau ba5a32361e fix previous commit (warning) 2023-06-29 17:03:03 +02:00
Andreas Fabri 00b540d791 Fix precomputed data 2023-06-29 15:34:03 +01:00
Laurent Rineau 15618b2916 fix CDT_3 
almost done
 2023-06-28 20:21:36 +02:00
Laurent Rineau 4b18c7208a fix warnings 2023-06-27 17:29:37 +02:00
Sébastien Loriot efd8b2d38b add more missing tests 2023-06-27 11:18:20 +02:00
Guillaume Damiand fe23441eab Merge master 2023-06-26 14:42:33 +02:00
Laurent Rineau a85ce74720 Merge branch 'Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6' into Triangulation_3-CDT_3-lrineau 2023-06-22 15:28:48 +02:00
Guillaume Damiand 7da9812bda Rename graphic_buffer into graphic_storage. 2023-06-22 15:18:34 +02:00
Sébastien Loriot dfc386d65b Merge branch 'master' into HEAD 2023-06-22 14:05:45 +02:00
Sébastien Loriot 573de7f29e Merge branch 'master' 2023-06-22 13:38:49 +02:00
Laurent Rineau 3851bc437e Merge pull request #7513 from sloriot/T23-exact_serialization 
EPECK Triangulation serialization
 2023-06-22 11:59:34 +02:00
Laurent Rineau 7e2e444825 Merge branch 'Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 2023-06-21 10:19:52 +02:00
Laurent Rineau 28ab0b7c3e another bug-fix 
Jane and I thought that case

  vertex-vertex with `ch_next != Cell_handle()`

was not possible. Let's patch that.
 2023-06-21 10:19:39 +02:00
Laurent Rineau d5f521c78c commit improvement to debugging code 2023-06-20 18:28:36 +02:00
Laurent Rineau 53d82e5007 Merge branch 'Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 2023-06-20 17:31:31 +02:00
Laurent Rineau 4a7f9269dc another bug fix?! 2023-06-20 17:31:13 +02:00
Laurent Rineau ad9efd0e18 Merge branch '5.6.x-branch' into Triangulation_3-fix_simplex_traverser-GF-CGAL-5.6 
# Conflicts:
#	STL_Extension/include/CGAL/Base_with_time_stamp.h
#	Triangulation_3/include/CGAL/Triangulation_3/internal/Triangulation_segment_traverser_3_impl.h
#	Triangulation_3/test/Triangulation_3/CMakeLists.txt
 2023-06-20 16:03:30 +02:00
Laurent Rineau fe0dc127a3 if-guard about C++17 2023-06-20 15:14:01 +02:00
Laurent Rineau 367466c434 Merge branch '5.5.x-branch' into Triangulation_3-fix_simplex_traverser-GF 2023-06-20 14:48:05 +02:00
Sébastien Loriot ccc5462b28 add missing include directives 2023-06-20 14:45:43 +02:00
Laurent Rineau 4f94c70740 typos 2023-06-19 17:15:42 +02:00
Laurent Rineau 6edb602729 factorize code when cells are traversed 2023-06-19 17:11:19 +02:00
Laurent Rineau 94a1d7efdb add special test cases 2023-06-19 17:06:31 +02:00
Laurent Rineau 14ff8c6af5 fix bugs 2023-06-19 17:06:10 +02:00
Laurent Rineau e936fcb36b factorize the debug function helpers 2023-06-18 21:20:19 +02:00
Laurent Rineau f193744e66 walk_to_next_3: reformat to indentation by 2 space 2023-06-16 18:35:14 +02:00
Laurent Rineau dcfd783953 change/fix some oddities in the code 2023-06-16 18:07:22 +02:00
Laurent Rineau 5a0c09d667 factorize/reformat the code 
The cases `chnext == {}` and `chnext != {}` were actually very
similar.
 2023-06-16 17:48:32 +02:00
Laurent Rineau 6b835a1799 use triangulation().tds().has_vertex to avoid dummies 2023-06-16 15:35:18 +02:00
Laurent Rineau 5c81b975ae triangulation() is now a reference 2023-06-16 15:33:02 +02:00
Laurent Rineau 80a4064350 chprev/chnext 2023-06-16 15:23:50 +02:00
Laurent Rineau 461b7689ea change the display of the test file 2023-06-16 15:00:29 +02:00
Laurent Rineau a2a736d074 fix last bug in the test file 2023-06-16 12:48:39 +02:00
Laurent Rineau 169985ea96 fix remaining cases even with permutations 
Now I am quite confident that the code is correct.
 2023-06-16 12:37:08 +02:00
Laurent Rineau 42f8b92c1d add comments 2023-06-16 11:50:35 +02:00
Sébastien Loriot f936680600 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 18:48:39 +02:00
Laurent Rineau 8207105503 fix accidental use of std::optional (boost:: instead) 2023-06-15 18:07:52 +02:00
Laurent Rineau a4a1e51e02 implementation permutations... and tests fail! 2023-06-15 17:25:16 +02:00
Laurent Rineau 8e7460108f fix case I131I 
The test case was wrong, because of non-exact floating points values,
in decimal.

All implemented test cases pass, now. And we do not expect missing
test cases.

Now, I should implement permutations of the four vertices of the tet.
 2023-06-15 17:06:08 +02:00
Laurent Rineau c7130e0c58 fix test case 131I 2023-06-15 16:41:07 +02:00
Laurent Rineau 4f20dc0f44 fix case 31 2023-06-15 15:50:51 +02:00
Laurent Rineau bec374fc86 add comments: actually only one missing case 2023-06-15 14:28:02 +02:00
Laurent Rineau f75f642b21 all test cases pass!! 
(this commit is a cosmetic change)

All test cases pass, but:
  - there are TODOs (missing cases 031, 030, 130, and 131.
  - we should test with permutations of the four vertices
 2023-06-15 13:21:11 +02:00
Laurent Rineau 6525e46d58 fix test case 232I 
the test case was wrong
 2023-06-15 13:17:05 +02:00
Laurent Rineau 9f4b8d5785 fix case I232 2023-06-15 13:16:28 +02:00
Laurent Rineau 00aa91967b `prev` then `cur` is more logic 2023-06-15 12:33:00 +02:00
Laurent Rineau e574a3a191 fix case 132I 2023-06-15 12:32:35 +02:00
Laurent Rineau 9cd8f0e8e1 fix case 12 2023-06-15 11:32:41 +02:00
Sébastien Loriot bbc4d08ee0 Merge remote-tracking branch 'cgal/master' into HEAD 2023-06-15 10:47:07 +02:00
Sébastien Loriot c8a88b9014 remove CGAL_static_assertion* 2023-06-15 10:42:10 +02:00
Laurent Rineau a26351455b Add comments about missing cases 2023-06-15 10:23:01 +02:00
Laurent Rineau b9eea8ec0d bug-fix test case 121 2023-06-14 21:12:15 +02:00
Laurent Rineau 7b039e3761 fix test cases for I032I, and I03 
`-.1`, and `.8` are not floating point values.

I have used `.125` (1/8) and `.5` instead.
 2023-06-14 17:57:50 +02:00
Laurent Rineau 311b04a0a7 bug-fix for case "0323 with bbox" 
The test-case was wrong.
 2023-06-13 17:32:29 +02:00
Laurent Rineau d5f5a6e2cd buf-fix for case 032I 2023-06-13 17:19:03 +02:00
Sébastien Loriot 8f54a3aa06 add missing test 2023-06-13 14:38:48 +02:00
Sébastien Loriot 2251c438fa enable exact serialization of triangulations with EPECK 2023-06-13 14:30:01 +02:00
Laurent Rineau 67b2d1c770 bug-fix of case "230 with bbox" 2023-06-12 18:06:40 +02:00
Laurent Rineau 5048eb960d bug-fix!! 
I have been working on that issue for a few days. Eventually I found
the bug.
 2023-06-12 16:45:16 +02:00
Laurent Rineau 5dceac54ef cosmetic changes 2023-06-12 16:43:51 +02:00
Laurent Rineau d6f6096518 test intersection before the other lines that may swap simplices 2023-06-12 16:38:42 +02:00
Laurent Rineau 01e22be3b6 Merge pull request #7496 from lrineau/Triangulation_3-fix_regular_with_TBB-GF 
Regular_triangulation_3: fix another race-condition
 2023-06-07 17:36:41 +02:00
Laurent Rineau 6ab1337951 Merge pull request #7496 from lrineau/Triangulation_3-fix_regular_with_TBB-GF 
Regular_triangulation_3: fix another race-condition
 2023-06-07 17:36:25 +02:00
Laurent Rineau 8cd8bc7b06 another fix of a race-condition 2023-06-04 20:49:02 +02:00
Sebastien Loriot b1b02d64fe
P3M3: Non-cubic domains, fixes, improvements (#7062) 
## Summary of Changes

- Add a dummy point generator that is agnostic to the periodic domain's
geometry, allowing P3M3 to handle non-cubic domain.
- Add an example of P3M3 running on polyhedral domains.
- Fix a few issues in SMDS_3's tet soup reading relating to
non-manifoldness + general IO code speed improvements.
- Fix a few issues in P3M3's medit output and always duplicate facets to
reduce the quantity of non-manifoldness occurences.
- Fix an issue with including Mesh_3 headers before P3M3's.
- Fix periodic point projection (for Mesh_3 optimizers) badly computing
the projection direction
- Robustify a handful of P3M3 functions that were using intermediate
constructions rather than the <Point, Offset> API (which uses filtered
predicates and thus yields proper robustness)
- Misc minor code cleaning / modernization

ToDo:
- [x] Check if some medit IO issues are fixed
- [x] Add non-manifoldness flag to read_MEDIT
- [x] Fix value of orthosphere_radius_threshold
- [x] Check calls of insert_dummy_points() (use generic)
- [x] Check doc of P3M3 about cubic domains requirement

Not done:
- [ ] Fix sharp features for periodic polyhedral domains (problems due
to changing weights creating cover change...). Code:
https://gist.github.com/MaelRL/357c52dc04e16a162f13a3c6860a1398; WIP
diff: https://gist.github.com/MaelRL/f98809964acffbacb6d3f42793e2654e

## Release Management

* Affected package(s): `Mesh_3`,  `P3M3`, `P3T3`, `SMDS3`
* Issue(s) solved (if any): Fix #6997, Fix #7214
* Feature/Small Feature (if any): TODO
* License and copyright ownership: no change
 2023-05-30 19:13:45 +02:00
Sebastien Loriot 11b92e94f8
Add an alternative of Mpzf using boost cpp_int (#7191) 
## TODO:
- [x] branch size
- [x] boost backend should not be the default in 5.6
 2023-05-22 09:23:35 +02:00
Laurent Rineau 2d324a2f09 Merge branch '5.5.x-branch' 2023-05-19 18:27:20 +02:00
Laurent Rineau f09c70bb96 Merge branch '5.4.x-branch' into 5.5.x-branch 2023-05-19 18:26:49 +02:00
Jane Tournois c7f75a9030 wip fixes for simplex traverser 
* test_segment_simplex_traverser_3 first failing test is now "032"
* the geometric intersection test fails because of doubles
 2023-05-16 18:35:54 +02:00
Laurent Rineau 5a85381d4c remove a trailing whitespace 
This time I think I managed to fix my VS Code  Insiders settings to fix that
issue permanently.
 2023-05-16 16:13:05 +02:00
Laurent Rineau 97262bf0e9 Triangulation_3: fix a race-condition in regular 
The race condition is in the batch insertion of a range
of points, with or without info.
 2023-05-16 15:56:32 +02:00
Jane Tournois 4bf7c45c8b replace std::tuple Simplex with a struct 
and then avoid all std std::get<i>(simplex), hard to read
 2023-05-15 13:06:37 +02:00
Laurent Rineau 4e14700ab4 Remove cases of OUTSIDE_AFFINE_HULL 2023-05-12 16:57:25 +02:00
Jane Tournois 087492b72d replace dealing with OUTSIDE_AFFINE_HULL 
with tests on cell_iterator == end()
 2023-05-12 16:13:30 +02:00
Laurent Rineau f181a8b7f7 additional bug-fix 2023-05-11 18:08:16 +02:00
Laurent Rineau d079559577 Merge pull request #7413 from lrineau/CGAL-fix-Qt5-CMake-GF 
Qt5::Svg is now only optional for CGAL_Qt5
 2023-05-11 16:55:28 +02:00
Laurent Rineau 2b94f06f57 Remove trailing whitespces 2023-05-11 16:32:34 +02:00
Laurent Rineau 7260a9497c Add debug tool 
Protected by the macro CGAL_DEBUG_TRIANGULATION_SEGMENT_TRAVERSER_3
 2023-05-11 16:18:16 +02:00
Laurent Rineau 6f22c113df WIP on the Triangulation_segment_cell_iterator_3 2023-05-11 15:13:16 +02:00
Laurent Rineau 152f0038fb improve the test process 
- call the API with two vertex handles, when possible,
- add a check that the reported simplices intersect the query segment,
- add a chech that two consecutive simplices are incident.
 2023-05-11 15:12:39 +02:00
Laurent Rineau 5a9d6d4998 cosmetic changes 2023-05-11 15:04:46 +02:00
Laurent Rineau 59d7a6306b cosmetic changes 2023-05-11 11:53:13 +02:00
Laurent Rineau 7a2c543b06 replace assert(false) by CGAL_unreachable() 2023-05-11 11:49:57 +02:00
Laurent Rineau 6325190a73 even more test cases 2023-05-09 12:35:09 +02:00
Laurent Rineau 4a0b1477f9 new test cases 2023-05-05 16:55:04 +02:00
Laurent Rineau 2220a1815a arg, a trailing whitespace! 2023-05-05 15:42:43 +02:00
Laurent Rineau 36b3491672 add a new test case vfefv for the simplex traverser 
For the moment, that new test fails.
 2023-05-05 15:30:43 +02:00
Mael 532b82cb9b
Merge branch 'master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-05-04 17:28:47 +02:00
Laurent Rineau d2bc415a15 Merge pull request #6950 from lrineau/CGAL-allow_Epick_with_float-GF 
Simple_precision_epick: an Epick-like kernel with float as FT
 2023-05-04 16:37:17 +02:00
Laurent Rineau f7b949834c Merge remote-tracking branch 'lrineau/Triangulation_3-fix_simplex_traverser-GF' into Triangulation_3-CDT_3-lrineau 2023-05-04 15:12:39 +02:00
Laurent Rineau dd738bf029 bug fix for the simplex traverser 2023-05-04 14:58:05 +02:00
Laurent Rineau 7a55a30b31 Merge remote-tracking branch 'afabri/STL_extension-Fix_Prevent_deref-GF' into Triangulation_3-CDT_3-lrineau 
# Conflicts:
#	Kernel_23/include/CGAL/Kernel/function_objects.h
#	Kernel_23/include/CGAL/Kernel/interface_macros.h
#	Polyhedron/demo/Polyhedron/Plugins/PMP/CMakeLists.txt
 2023-05-02 16:05:54 +02:00
Guillaume Damiand 519c7cc1a5 rename add_in_graphic_buffer into add_in_graphic_storage 2023-04-28 15:25:40 +02:00
Laurent Rineau 0576e883f9 Merge branch 'CGAL-fix-Qt5-CMake-GF' into CGAL-Qt6-GF 
# Conflicts:
#	AABB_tree/demo/AABB_tree/CMakeLists.txt
#	Alpha_shapes_3/demo/Alpha_shapes_3/CMakeLists.txt
#	Arrangement_on_surface_2/demo/Arrangement_on_surface_2/CMakeLists.txt
#	Circular_kernel_3/demo/Circular_kernel_3/CMakeLists.txt
#	GraphicsView/demo/Alpha_shapes_2/CMakeLists.txt
#	GraphicsView/demo/Apollonius_graph_2/CMakeLists.txt
#	GraphicsView/demo/Bounding_volumes/CMakeLists.txt
#	GraphicsView/demo/Circular_kernel_2/CMakeLists.txt
#	GraphicsView/demo/Generator/CMakeLists.txt
#	GraphicsView/demo/GraphicsView/CMakeLists.txt
#	GraphicsView/demo/L1_Voronoi_diagram_2/CMakeLists.txt
#	GraphicsView/demo/Largest_empty_rect_2/CMakeLists.txt
#	GraphicsView/demo/Periodic_2_triangulation_2/CMakeLists.txt
#	GraphicsView/demo/Polygon/CMakeLists.txt
#	GraphicsView/demo/Segment_Delaunay_graph_2/CMakeLists.txt
#	GraphicsView/demo/Segment_Delaunay_graph_Linf_2/CMakeLists.txt
#	GraphicsView/demo/Snap_rounding_2/CMakeLists.txt
#	GraphicsView/demo/Spatial_searching_2/CMakeLists.txt
#	GraphicsView/demo/Stream_lines_2/CMakeLists.txt
#	GraphicsView/include/CGAL/Qt/DemosMainWindow_impl.h
#	Hyperbolic_triangulation_2/demo/Hyperbolic_triangulation_2/CMakeLists.txt
#	Installation/cmake/modules/CGAL_add_test.cmake
#	Linear_cell_complex/demo/Linear_cell_complex/CMakeLists.txt
#	Optimal_transportation_reconstruction_2/demo/Optimal_transportation_reconstruction_2/CMakeLists.txt
#	Periodic_3_triangulation_3/demo/Periodic_3_triangulation_3/CMakeLists.txt
#	Periodic_3_triangulation_3/demo/Periodic_Lloyd_3/CMakeLists.txt
#	Polyhedron/demo/Polyhedron/polyhedron_demo_macros.cmake
#	Polyline_simplification_2/demo/Polyline_simplification_2/CMakeLists.txt
#	Principal_component_analysis/demo/Principal_component_analysis/CMakeLists.txt
#	Triangulation_3/demo/Triangulation_3/CMakeLists.txt
#	Triangulation_on_sphere_2/demo/Triangulation_on_sphere_2/CMakeLists.txt
 2023-04-28 13:49:58 +02:00
Guillaume Damiand 4df2edd9c1 Replace draw_buffer by draw_graphic_storage 2023-04-28 12:26:31 +02:00
Laurent Rineau fe5a36c08e fix all the CMakeLists.txt for Qt5 2023-04-27 17:27:37 +02:00
Guillaume Damiand 8f29e4d323 Rename class graphic buffer 2023-04-27 15:48:42 +02:00
Laurent Rineau 2a41598bd7 cosmetic changes (indent, spaces, naming) 2023-04-27 12:04:02 +02:00
Andreas Fabri 68261eb0f1 STL_extension: Add parameter for value type to Prevent_deref 2023-04-26 10:55:59 +01:00
Laurent Rineau 67441a3772 Convert all CMakeLists.txt to Qt6 2023-04-25 17:27:03 +02:00
Sébastien Loriot b039040f73 boost::is_convertible -> std::is_convertible 2023-04-23 22:37:07 +02:00
Sébastien Loriot 7b85df810d boost::add_const -> std::add_const 2023-04-23 22:37:07 +02:00
Sébastien Loriot 5a8736d666 fix typo 2023-04-23 18:55:02 +02:00
Sébastien Loriot 99e7f4806a boost::int -> std::int 2023-04-23 18:43:10 +02:00
Laurent Rineau 205236832e Merge remote-tracking branch 'cgal/master' into CGAL-rename_ctest_test_names-GF 
# Conflicts:
#	Polyhedron/demo/Polyhedron/Plugins/PMP/CMakeLists.txt
 2023-04-21 10:47:17 +02:00
Andreas Fabri 0574c6ba4c Change the remaining CMakeLists.txt [skip ci] 2023-04-20 16:35:14 +01:00
Laurent Rineau ba187d5491 improve readability of the function prototype 2023-04-19 18:04:16 +02:00
Laurent Rineau 430c49124a reindent 2023-04-19 18:03:41 +02:00
Laurent Rineau 90170bda13 bug-fix: restore more info on incident facets of Steiner poitns 2023-04-19 18:03:07 +02:00
Laurent Rineau b324b40dd0 insert_Steiner_point_on_subconstraint 2023-04-19 17:42:23 +02:00
Laurent Rineau 2e80c46ba6 prefix output files by "dump_" 2023-04-19 17:15:44 +02:00
Andreas Fabri 11f8ffd6a0 Undo accidental change 2023-04-18 09:49:41 +01:00
Andreas Fabri ced52508fd Add IO operators 2023-04-18 09:48:10 +01:00
Laurent Rineau 824976a003 Merge pull request #7236 from albert-github/feature/issue_7231 
issue #7231 Improvement of layout of refines relations.
 2023-04-17 10:14:01 +02:00
Andreas Fabri e0150d09ff Add a generator for ocean like data sets 2023-04-14 09:03:32 +01:00
Andreas Fabri 257f0d253b Add a generator for ocean like data sets 2023-04-14 09:01:59 +01:00
Laurent Rineau 11ff3c57bd
Merge branch 'master' into CGAL-boost_mp_exact_ring_selector 2023-04-14 09:44:23 +02:00
Laurent Rineau 3b79468b13 another USBAN error, about uninitialized bool 2023-04-13 17:26:44 +02:00
Andreas Fabri e2623285b6 Undo change in CMakeLists.txt 2023-04-13 16:16:45 +01:00
Andreas Fabri 1d41c0d569 More early exits 2023-04-13 16:15:18 +01:00
Laurent Rineau 1dce90ee79 Merge remote-tracking branch 'cgal/master' into CGAL-allow_Epick_with_float-GF 2023-04-07 10:59:51 +02:00
Sébastien Loriot 96bf9c9cb8 fix includes 2023-04-07 10:45:12 +02:00
Andreas Fabri 965245baf5 resolve conflict 2023-04-07 09:14:16 +01:00
Andreas Fabri 80eebff78d bug fix. todo: remove debug assertions 2023-04-05 15:28:33 +01:00
Laurent Rineau b34aeef800 Warn about missing subfaces 2023-03-21 10:04:22 +01:00
Laurent Rineau ed5e0c20ad tweaks around CGAL_DEBUG_CDT_3 2023-03-21 10:04:22 +01:00
Laurent Rineau f32f9f0da1 Change normals of CDT_2s... 
... honestly that does not change anything!
 2023-03-21 10:04:22 +01:00
Laurent Rineau b561b86133 Add Compare_xy_2 to TriangulationTraits_2 
This enables customization of projection traits for CDT_2s and
facilitates unification with the predicates utilized in
3D triangulations.
 2023-03-21 10:01:29 +01:00
Laurent Rineau 87840d889d WIP: insert bbox points 
That is a workaround to avoid polygons on convex hulls.
 2023-03-20 16:27:48 +01:00
Mael Rouxel-Labbé cd0c81a98a Merge remote-tracking branch 'cgal/master' into P3M3-Undocumented_polyhedral_domain_example-GF 2023-03-20 10:14:27 +01:00
Laurent Rineau d52369a25b Use argv[2] instead of `dump.off`, for the output file name 2023-03-17 13:28:06 +01:00
Laurent Rineau 27e50d43e1 Facet can be recovered by other operation 2023-03-17 13:27:20 +01:00
Andreas Fabri 0d320e48a8 Merge branch 'Number_types-fix_VC2017_boost_mp-GF' into CORE-boost_mp_number-GF 2023-03-17 08:28:10 +01:00
Laurent Rineau aecc195697 Fix region ids 2023-03-16 14:11:05 +01:00
Laurent Rineau 549ff7bdb0 Fix typo 2023-03-16 14:00:12 +01:00
Laurent Rineau d2cef5f1c4 fill_cdt_2 takes a reference to the CDT_2 object 2023-03-15 17:00:48 +01:00
Laurent Rineau 5c339515cf Merge branch 'CGAL-rename_ctest_test_names-GF' into Triangulation_3-CDT_3-lrineau 
# Conflicts:
#	Polygon_mesh_processing/examples/Polygon_mesh_processing/CMakeLists.txt
#	Triangulation_3/benchmark/Triangulation_3/CMakeLists.txt
 2023-03-15 14:32:28 +01:00
Laurent Rineau 2f0203be10 Merge pull request #7255 from lrineau/CGAL-rename_ctest_test_names-GF 
CGAL CTest support: rename the test names

# Conflicts:
#	Mesh_3/test/Mesh_3/CMakeLists.txt
 2023-03-15 14:23:32 +01:00
albert-github 2d60f46985 issue #7231 Improvement of layout of refines relations. 
- Adjusted cgalRefines according to reviews
- Implemented it in all files
 2023-03-14 17:37:50 +01:00
Laurent Rineau 25b0c9aaa4 Fix a bug with markers of constrained facets 2023-03-13 16:18:53 +01:00
Laurent Rineau e762d7a719 Rename a variable 2023-03-13 16:18:18 +01:00
Laurent Rineau 6d54b9a9b2 Add an assertion 2023-03-13 16:16:56 +01:00
Laurent Rineau a8e06c3c4f Better assertion 2023-03-13 14:35:31 +01:00
Laurent Rineau 08c007a00e Add method `recheck_constrainted_Delaunay` 2023-03-13 14:32:43 +01:00
Laurent Rineau c99f0c5940 code to maintain the list of missing subfaces 2023-03-10 10:38:25 +01:00
Laurent Rineau a480a1dde8 triangulate_cavity counts the number of added vertices 2023-03-09 15:57:46 +01:00
Laurent Rineau feb3647820 Use std::set directly instead of std::vector 2023-03-09 15:56:53 +01:00
Laurent Rineau 9678e09077 restore_subface_region now works!! 
I will have to refactor it because it is too long: more than 300 lines currently!
 2023-03-09 13:01:17 +01:00
Laurent Rineau ccb8b0533f a new assertion about cavity triangulations 2023-03-09 12:57:36 +01:00
Laurent Rineau bee2138b01 Those helper functions can be static 2023-03-09 12:56:43 +01:00
Laurent Rineau bc1b43e532 cosmetic changes with clang-format 2023-03-09 12:56:16 +01:00
Laurent Rineau bdbe6c2646 Again a warning about non-coplanar polygons 2023-03-09 12:55:28 +01:00
Laurent Rineau 4aa227060d Better Next_face exception, with a message 2023-03-09 12:54:52 +01:00
Laurent Rineau 81580c3e85 Detect non-coplanar polygons 2023-03-09 12:52:52 +01:00
Laurent Rineau 90387d3f5b Write the result to dump.off 2023-03-09 12:52:17 +01:00
Laurent Rineau 31d4512108 cleanup CGAL_DEBUG_CDT_3 2023-03-09 11:50:19 +01:00
Laurent Rineau c86c0fea01 Use new oformat possibilitities 2023-03-09 11:40:51 +01:00
Laurent Rineau 9b8cdec2d4 Triangulation_3: rewrite the code a little 
that avoids code like `o_vt_f_pair.second.first`

Backport: master
 2023-03-09 11:29:26 +01:00
Laurent Rineau 8ae9a279a4 CDT: add tests 2023-03-08 17:01:58 +01:00
Laurent Rineau efe3822f33 Merge pull request #7115 from MaelRL/T3-test_cleaning-GF 
(Partial) Cleaning of Triangulation_3 tests
 2023-03-02 13:42:29 +01:00
Laurent Rineau 642a3d93ea write_facets needs a ref to the triangulation 2023-02-26 15:46:01 +01:00
Laurent Rineau 5a20fd8567 Merge pull request #7238 from albert-github/feature/bug_author_consistency 
Making description of author(s)  of a package consistent
 2023-02-24 16:14:43 +01:00
Laurent Rineau e5b722aa93 Fix a warning about a copy in range-foor loop 2023-02-21 13:35:27 +01:00
Laurent Rineau fa07828cfe Deal with -DDCGAL_NO_DEPRECATED_CODE 2023-02-21 13:35:08 +01:00
Sébastien Loriot 9e72361537 All packages depends now on CGAL_Core (like Kernel) 2023-02-20 15:24:16 +01:00
Laurent Rineau a5052f4cd8 Merge pull request #6835 from MaelRL/CGAL-Clean_CMakeLists.txt-GF 
Some CMakeLists.txts cleaning
 2023-02-16 10:52:29 +01:00
Laurent Rineau 46fb757b57 Rework CGAL_DEBUG_CDT_3 2023-02-13 18:17:59 +01:00
Laurent Rineau 8bbc560920 WIP: not coplanar! 2023-02-13 18:07:49 +01:00
Laurent Rineau 75f871b94c Allow to compile with Epeck 2023-02-13 16:56:05 +01:00
Laurent Rineau b2dc7cf1d2 WIP: Triangulate cavities 2023-02-13 15:44:46 +01:00
Laurent Rineau daa2f6f23e Fix a warning 2023-02-13 15:44:03 +01:00
Laurent Rineau ca4ec2bbd6 Merge pull request #7255 from lrineau/CGAL-rename_ctest_test_names-GF 
CGAL CTest support: rename the test names
 2023-02-06 15:15:07 +01:00
Laurent Rineau bb363119be Merge pull request #7246 from lrineau/Triangulation_3-refactorize_remove_functions-GF 
Triangulation_3.h: Rewrite/factorize remove functions
 2023-02-06 15:05:59 +01:00
Laurent Rineau 89c5d7aa7f Remove the call to sort to avoid determinism issues 2023-02-06 15:04:36 +01:00
Laurent Rineau 764d91b25b Cosmetic changes 2023-02-06 15:04:36 +01:00
Laurent Rineau 0fa04af099 Split function restore_subface_region 
Now there is a function `construct_cavities`, of 130 lines.
That is more than enough.
 2023-02-06 15:04:36 +01:00
Laurent Rineau 67c7c9045d Collect facets of upper and lower cavities 2023-02-06 15:04:36 +01:00
Laurent Rineau cebea91180 Gather facets of upper/lower cavities 2023-02-06 15:04:36 +01:00
Laurent Rineau ba9ddb36c7 Remove a duplicate in intersecting_edges 2023-02-06 15:04:36 +01:00
Laurent Rineau 6b671bfbc5 Debug: dump all interesting regions 2023-02-06 15:04:36 +01:00
Laurent Rineau bec251d59c Add a better way to deal with "already visited" 2023-02-06 15:04:36 +01:00
Laurent Rineau 6ecf273af7 Better handling of the exceptional case `Next_face` 
`processed_faces.insert(fh_region.begin(), fh_region.end());` is done before
the assertion is thrown.
 2023-02-06 15:04:36 +01:00
Laurent Rineau 8bf2a0e69a Use a custom intersect test, report oriented edge 
Now the first vertex of the edge is above the region
 2023-02-06 15:04:36 +01:00
Laurent Rineau e25ecbe424 Different choice of normal, not really better 
- perfect for `cube_quad.off`,
- but not for `mpi.off`.

The truth is out there.
 2023-02-06 15:04:36 +01:00
Laurent Rineau f0c60d8d23 WIP: the set of intersecting edges is constructed 
That seems to work.
 2023-02-06 15:04:36 +01:00
Laurent Rineau 3a23114476 Reduce debug informations, by default 2023-02-06 15:04:36 +01:00
Laurent Rineau d2d841f3dc Debug info about the polygon id 2023-02-06 15:04:36 +01:00
Laurent Rineau 29cd77764f refactor: extract fct does_edge_intersect_region 2023-02-06 15:04:36 +01:00
Laurent Rineau ded672a308 Use a border edge 2023-02-06 15:04:36 +01:00
Laurent Rineau 7b9bcb8dc3 Add const to for-loop 2023-02-06 15:04:36 +01:00
Laurent Rineau 9602eede86 Extract a fct search_first_intersection 2023-02-06 15:04:36 +01:00
Laurent Rineau 00d815ecb3 Refactor, reindent restore_constrained_Delaunay 2023-02-06 15:04:36 +01:00
Laurent Rineau 155f6791a2 Use std::optional<Edge> instead of bool 2023-02-06 15:04:36 +01:00
Laurent Rineau e03c0f36ce WIP: now that assertion no long fail 2023-02-06 14:42:28 +01:00
Laurent Rineau 8dec1ab3b3 WIP: new assertion, that crashes 2023-02-06 14:42:28 +01:00
Laurent Rineau 78c3e0b342 Fix a stupid bug when the constraint is reversed 2023-02-06 14:42:28 +01:00
Laurent Rineau 0a86d2d62f Use <format> to display new debug information 2023-02-06 14:42:28 +01:00
Laurent Rineau b2fdc15f71 Improve debugging 2023-02-06 14:42:28 +01:00
Laurent Rineau 907e13e0d6 Use Output_rep to display debug info 2023-02-06 14:42:21 +01:00
Laurent Rineau 1a9c20b5c0 Use Base_with_time_stamp 2023-02-06 14:41:56 +01:00
Laurent Rineau cddb01ab68 Merge pull request #7253 from lrineau/Triangulation_2-improve-CDT_2_debugging-GF 
STL_Extension/Triangulation_2: improve CDT_2 debug messages
 2023-02-06 14:17:40 +01:00
Laurent Rineau 6df18b668c CGAL CTest support: rename the test names 
Now that CTest test names can contain whitespace, we can have
better looking names. That is also more practicle because we can now
copy-paste the target name in `compilation of  <target_name>`.
 2023-02-06 12:04:57 +01:00
Laurent Rineau 029b5bead5 Triangulation_3.h: Rewrite/factorize 
New functions:
  - `create_hole_outer_map`,
  - `create_triangulation_inner_map`.
  - `copy_triangulation_into_hole`,
  - `fill_auxiliary_triangulation_with_vertices_around_v`
 2023-02-06 10:02:25 +01:00
Laurent Rineau 686aff651d Triangulation_3.h: Factorize the two versions of make_hole_3D 2023-02-06 10:02:20 +01:00
Laurent Rineau d940c3ae3f Triangulation_3.h: make_vertex_triple can be static 2023-02-06 10:02:15 +01:00
albert-github 57e900b47c Making description of author(s) of a package consistent 
- use `\cgalPckAuthor` in case of one author
- use of `\cgalPckAuthors` in case of multiple authors
- using in case of multiple authors always `, and `
- in the 1.9.6 `BaseDoxyfile.in` let the `\cgalPckAuthors` point to `\cgalPckAuthor` to get consistent output (not done for other versions as in the past the `ALIASES` could not call one another).
 2023-02-02 18:40:44 +01:00
Sébastien Loriot 9e137bca24 Merge 'cgal/master' 2023-01-31 12:26:55 +01:00
Mael 153c603209
Merge branch 'master' into CGAL-Clean_CMakeLists.txt-GF 2023-01-27 22:09:02 +01:00
Mael fe8262b85a
Merge branch 'master' into T3-test_cleaning-GF 2023-01-27 21:49:54 +01:00